Run tests on ruby 3.4.1 #448
Merged
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
suggested changes
Jun 2, 2025
Contributor
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
/opt/hostedtoolcache/Ruby/3.4.0/x64/lib/ruby/gems/3.4.0+1/gems/minitest-5.18.1/lib/minitest.rb:3: warning: mutex_m was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add mutex_m to your Gemfile or gemspec to silence this warning.
/opt/hostedtoolcache/Ruby/3.4.0/x64/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- mutex_m (LoadError)
But looking at theforeman/smart_proxy_salt#107 it also needs to add csv. With https://community.theforeman.org/t/smart-proxy-ci-now-running-on-ruby-3-4/43409 we're starting to run into this with various Smart Proxy plugins so it would be good to see it resolved.
Contributor
Author
|
I have had some issue with sqlite with this, let's see what ghas think |
ekohl
reviewed
Jun 2, 2025
.github/workflows/ruby.yml
Outdated
| - 2.7.0 | ||
| - 3.0.0 | ||
| - 3.2.0 | ||
| - 3.4.3 |
Contributor
There was a problem hiding this comment.
Any reason you're not using 3.4?
Contributor
Author
There was a problem hiding this comment.
On ruby 3.4.0, I'm getting a lot of errors related to native extension loading
Dynflow::Executors::Parallel::Core::execution of run flow::suspended action::works when resumed after error#test_0001_anonymous:
Sequel::AdapterNotFound: LoadError: cannot load such file -- sqlite3/sqlite3_native
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'Kernel.require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sqlite3-2.6.0-x86_64-linux-gnu/lib/sqlite3.rb:6:in '<top (required)>'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'Kernel.require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sequel-5.93.0/lib/sequel/adapters/sqlite.rb:3:in '<top (required)>'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'Kernel.require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/3.4.0+1/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sequel-5.93.0/lib/sequel/database/connecting.rb:84:in 'Sequel::Database.load_adapter'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sequel-5.93.0/lib/sequel/database/connecting.rb:17:in 'Sequel::Database.adapter_class'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sequel-5.93.0/lib/sequel/database/connecting.rb:36:in 'Sequel::Database.connect'
/home/vagrant/.asdf/installs/ruby/3.4.0/lib/ruby/gems/3.4.0+1/gems/sequel-5.93.0/lib/sequel/core.rb:124:in 'Sequel::SequelMethods#connect'
/home/vagrant/dynflow/lib/dynflow/persistence_adapters/sequel.rb:312:in 'Dynflow::PersistenceAdapters::Sequel#initialize_db'
/home/vagrant/dynflow/lib/dynflow/persistence_adapters/sequel.rb:58:in 'Dynflow::PersistenceAdapters::Sequel#initialize'
/home/vagrant/dynflow/test/test_helper.rb:119:in 'Class#new'
/home/vagrant/dynflow/test/test_helper.rb:119:in 'WorldFactory.persistence_adapter'
/home/vagrant/dynflow/test/test_helper.rb:128:in 'WorldFactory.clean_coordinator_records'
/home/vagrant/dynflow/test/test_helper.rb:238:in 'Minitest::Test#setup'
This seems to be resolved in ruby-3.4.1, with the only change between .0 and .1 being version numbers changes. Guess this could cause ruby to look for native extensions in wrong place?
Contributor
There was a problem hiding this comment.
3.4 should refer to the latest 3.4.x.
Ruby 3.4.3
> {'a' => { 'b' => { 'c' => ['asdf'] } } }.inspect
"{\"a\" => {\"b\" => {\"c\" => [\"asdf\"]}}}"
Ruby 3.0.7
> "{\"a\"=>{\"b\"=>{\"c\"=>[\"asdf\"]}}}"
Contributor
Author
|
We're greenish, 3.0.0 seems to have gotten stuck on an unrelated thing and mysql in gha has been busted for ages. |
ekohl
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.