Skip to content

Conversation

@nadjaheitmann
Copy link
Contributor

No description provided.

@sbernhard sbernhard merged commit 3db9ea5 into master May 28, 2025
19 checks passed
@ekohl ekohl deleted the fix-ruby-3.4-ci branch June 2, 2025 07:45
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should have been a PR to dynflow. Dynflow/dynflow#448 is the proper place to fix it.

@nadjaheitmann
Copy link
Contributor Author

This really should have been a PR to dynflow. Dynflow/dynflow#448 is the proper place to fix it.

True. But it is just added to the 'test' group, so I don't think it's too big of a deal.

@ekohl
Copy link
Member

ekohl commented Jun 2, 2025

I think it's always a good practice to leave a comment pointing to the real issue and to make sure there's progress on it. Other Smart Proxy plugins will run into it as well and it's more efficient to solve it at the root.

@nadjaheitmann
Copy link
Contributor Author

I think it's always a good practice to leave a comment pointing to the real issue and to make sure there's progress on it. Other Smart Proxy plugins will run into it as well and it's more efficient to solve it at the root.

True, will try to remember next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants