Refactor using AI agent, new features: #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The exporter remains running and log to scrape failure metric in case of: not root, nvme-cli not found, or unsupported version * OCP metrics are automatically scraped if available or a message logged to stdout if not * Simplified the `nvme-cli` compatibility accepting anything above v2.8 * Added a simple html page if not hitting the `/metrics` endpoint * CLI flags now align to Prometheus Node exporter format * There are now three collectors enabled by default: smart, info and ocp; it is possible to enable/disable them at CLI * Added all metric descriptions * Improved Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvme-clicompatibility accepting anything above v2.8/metricsendpoint