Feature/test-smb264-jetson #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node, and updating robot description generation.
…k topic to rc_vel, modify low-level controller node parameters, and uncomment relevant nodes in launch description.
…uding necessary nodes and configurations for simulation environment.
…unch configuration.
…amera', change pixel format to 'RGB8', and modify serial number for Jetson. Add image processing container for RGB camera.
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up obsolete launch files, standardizes the RGB camera pipeline for SMB264 on Jetson, and updates related configuration and installation.
- Removed legacy and redundant launch scripts (e.g.,
smb_nuc_system,smb,motor_controller,jetson_rgb_camera,flir_camera). - Refactored
sensors.launch.pyto only include the RGB camera group and animage_proccontainer, and updated the camera serial for Jetson. - Enhanced
rgb_camera_driver.launch.pywith dynamic calibration file lookup, updated default camera name/serial, and adjusted image parameters. - Updated camera YAMLs to reflect new
camera_name, added atwist_mux_topics.yamlconfig, and extended CMake install to includerviz.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| launch/sensors.launch.py | Kept only RGB camera group and image_proc container, updated serial |
| launch/rgb_camera_driver.launch.py | Added dynamic calibration file logic, updated defaults and pixel format |
| config/smb264_cam0.yaml | Changed camera_name from 0 to rgb_camera |
| config/smb261_cam0.yaml | Changed camera_name from 0 to flir_camera |
| config/twist_mux_topics.yaml | New twist mux topic configuration |
| CMakeLists.txt | Added rviz directory to install target |
| launch/*.launch.py (5 files) | Removed obsolete launch scripts |
Comments suppressed due to low confidence (4)
launch/sensors.launch.py:26
- ComposableNodeContainer and ComposableNode are used here but not imported; add
from launch_ros.actions import ComposableNodeContainerandfrom launch_ros.descriptions import ComposableNodeto prevent runtime errors.
container = ComposableNodeContainer(
launch/sensors.launch.py:13
- [nitpick] There are large blocks of commented-out code above; consider removing legacy comments or moving them to a separate branch to keep this file concise and maintainable.
rgb_camera_group = GroupAction([
launch/rgb_camera_driver.launch.py:22
- [nitpick] The
PythonExpressionimport is not used in this file; removing unused imports can improve readability.
from launch.substitutions import PathJoinSubstitution, PythonExpression
CMakeLists.txt:15
- Ensure that the
rvizdirectory exists in the project before installing; otherwise CMake will warn about a missing directory.
rviz
NileshBalu
requested changes
Jun 23, 2025
There was a problem hiding this comment.
This rviz line gives an error while building on the jetson
There was a problem hiding this comment.
shouldn't this file be renamed with subscript jetson?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.