Make sure that we pick up new definition of typetree #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
force-pushed
the
vc/extendable_typetree
branch
from
a87f1e8 to
2687373
Compare
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/18046036049/artifacts/4118023165. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
+ Coverage 75.33% 76.16% +0.82%
==========================================
Files 57 11 -46
Lines 17776 709 -17067
==========================================
- Hits 13392 540 -12852
+ Misses 4384 169 -4215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wsmoses
reviewed
Sep 5, 2025
| A wrapper around `typetree` that ensures the call happens in the correct world for GPUCompiler. | ||
| Useful when using typetree from a generated function since typetree is user-extendable. | ||
| """ | ||
| function typetree_total(@nospecialize(job::GPUCompiler.CompilerJob), @nospecialize(T), ctx, dl, seen=TypeTreeTable()) |
There was a problem hiding this comment.
For clarity could we call this in world instead of total?
vchuravy
force-pushed
the
vc/extendable_typetree
branch
from
72dc55c to
7cebe77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.