-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Reuse existing QBD connection across workspaces #86909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
9dfa52e
add `adminPoliciesConnectedToQBDSelector`
lakchote c0843c8
add `useAdminPoliciesConnectedToQBD` hook
lakchote 449d6ad
add `useHasPoliciesConnectedToQBD` hook
lakchote 16eea2d
add QBD existing connections route
lakchote eb3eb5a
add QBD reuse existing connections screen
lakchote 2dace0f
add QBD existing connections nav params
lakchote 89b40ad
add QBD existing connections linking config
lakchote 4cbcee0
add QBD existing connections to RHP
lakchote f5aedbc
add QBD existing connections navigator
lakchote d1350cc
add QBD existing connections page
lakchote ea301fa
add reuse check to QBD connect flow
lakchote 5b5c109
add reuse check to QBD connect flow native
lakchote e536fb6
add QBD case to `copyExistingPolicyConnection`
lakchote f930c8a
refactor `existingConnections` param, add QBD
lakchote bf09195
update call sites for `existingConnections`
lakchote e122220
update AccountingContext for `existingConnections`
lakchote 5968cd1
Merge remote-tracking branch 'origin/main' into lucien/fix-qbd-reuse-…
lakchote c872b27
add `hasPoliciesConnectedToQBDSelector`
lakchote 3e2e8fd
use onyx selector in `useHasPoliciesConnectedToQBD`
lakchote bf416ce
use `useHasPoliciesConnectedToQBD` in flow
lakchote 3a66454
memoize `menuItems` in QBD existing connections
lakchote 4748f28
use `getIntegrationLastSuccessfulDate` for sync date
lakchote e9714cd
Merge remote-tracking branch 'origin/main' into lucien/fix-qbd-reuse-…
lakchote 24ff078
add tests for QBD policy selectors
lakchote 8320bf2
fix null to undefined in QBD selector test
lakchote 4e3da84
restore `policyID` in useEffect deps
lakchote 2e1f1d1
fix run QBD flow redirect only on mount
lakchote 0cc4290
fix run QBD flow redirect only on mount (native)
lakchote eed1026
add comment explaining eslint-disable in QBD flow
lakchote 4cedc45
add comment explaining eslint-disable in QBD flow (native)
lakchote 96f9bce
merge origin/main into lucien/fix-qbd-reuse-connection
lakchote eb83c2b
Merge branch 'main' into lucien/fix-qbd-reuse-connection
lakchote c7de772
add create new connection option to QBD existing connections page
lakchote 313bf0c
Merge branch 'main' into lucien/fix-qbd-reuse-connection
lakchote 0ab336b
try to get rid of spellcheck cache
lakchote 3819d31
remove space
lakchote 64daeb8
rename to
lakchote 536534c
Merge main into lucien/fix-qbd-reuse-connection
lakchote 6be81a2
add `getQuickbooksDesktopSetupEntryRoute()`
lakchote 4eb6ad8
fix qbd setup entry in web flow
lakchote 2c10bae
fix qbd setup entry in native flow
lakchote 3dcb931
fix qbd create connection route
lakchote ceb2fd9
update qbd upgrade fallback route
lakchote fce5a62
add test for qbd setup entry route
lakchote e86df30
add test for qbd reuse flow
lakchote 0354793
fix qbd required-device back navigation
lakchote e7d4847
fix qbd setup page back navigation
lakchote 3f62dcd
Merge remote-tracking branch 'origin/main' into lucien/fix-qbd-reuse-…
lakchote c5e7e67
remove unneeded file
lakchote fc3ee20
Merge main into lucien/fix-qbd-reuse-connection
lakchote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
src/components/ConnectToQuickbooksDesktopFlow/index.native.tsx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import {adminPoliciesConnectedToQBDSelector} from '@src/selectors/Policy'; | ||
| import useOnyx from './useOnyx'; | ||
|
|
||
| function useAdminPoliciesConnectedToQBD() { | ||
| const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY); | ||
| return adminPoliciesConnectedToQBDSelector(policies); | ||
| } | ||
|
|
||
| export default useAdminPoliciesConnectedToQBD; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import {hasPoliciesConnectedToQBDSelector} from '@src/selectors/Policy'; | ||
| import useOnyx from './useOnyx'; | ||
|
|
||
| function useHasPoliciesConnectedToQBD() { | ||
| const [hasPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: hasPoliciesConnectedToQBDSelector}); | ||
| return hasPolicies ?? false; | ||
| } | ||
|
|
||
| export default useHasPoliciesConnectedToQBD; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we renaming this in this PR? Is this from a bad conflict resolution?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's to fix this error that showed up since we've touched the file:
https://github.com/Expensify/App/actions/runs/23917005575/job/69753374824