Reuse existing QBD connection across workspaces

[lakchote]

Explanation of Change

Enables the user to reuse existing QBD connection across workspaces

Fixed Issues

$ #86674
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

1. Connect to QBD on a workspace
2. Switch to another workspace
3. You should be able to reuse the existing connection from the previous workspace
4. Click on it
5. The existing connection is successfully imported to the new workspace

Video test

Screen.Recording.2026-04-02.at.20.21.52.mov

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console
  Same as in tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
• I verified that similar component doesn't exist in the codebase
• I verified that all props are defined accurately and each prop has a /** comment above it */
• I verified that each file is named correctly
• I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
• I verified that the only data being stored in component state is data necessary for rendering and nothing else
• In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
• I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
• I verified that all JSX used for rendering exists in the render method
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	16.23% <100.00%> (+0.25%)	⬆️
src/SCREENS.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
...s/workspace/accounting/AccountingContext/index.tsx	0.00% <ø> (ø)
...ce/accounting/qbd/RequireQuickBooksDesktopPage.tsx	0.00% <ø> (ø)
src/pages/workspace/accounting/qbd/utils.ts	100.00% <100.00%> (ø)
src/selectors/Policy.ts	64.00% <100.00%> (+1.50%)	⬆️
...omponents/ConnectToQuickbooksDesktopFlow/index.tsx	87.50% <80.00%> (+87.50%)	⬆️
src/hooks/useAdminPoliciesConnectedToQBD.ts	0.00% <0.00%> (ø)
... and 8 more
... and 12 files with indirect coverage changes

[lakchote]

@ahmedGaber93 I've fixed it

Screen.Recording.2026-04-06.at.20.14.52.mp4

[ahmedGaber93]

Retesting

[ahmedGaber93]

@lakchote Just to confirm—on native/mWeb, should the “go back” action return to “Connect to QuickBooks Desktop” instead of “Accounting”?

20260406210003646.mp4

I think it currently goes back to “Accounting”, since on web, when this screen is opened, QuickBooks is already enabled, so there’s no need to return to the existing connection flow. However, on native/mWeb the flow is different and shows a “cannot connect from this device” message.

20260406210251956.mp4

Is this expected behavior, or should we treat it as an issue?

[lakchote]

@ahmedGaber93 good point, in other flows we're using the dismiss modal mechanism, but for QBD I think it makes sense to go back to the previous page here. I've updated the code.

[ahmedGaber93]

20260407211149437.mp4

20260407212035398.mp4

20260407212401307.mp4

[ahmedGaber93]

@lakchote Test again and it works well. All yours!

[francoisl]

Tested locally and works well, a couple small comments.

[francoisl]

Why are we renaming this in this PR? Is this from a bad conflict resolution?

[lakchote]

Is this from a bad conflict resolution?

No, it's to fix this error that showed up since we've touched the file:

https://github.com/Expensify/App/actions/runs/23917005575/job/69753374824

[lakchote]

@francoisl ready for review again

[github-actions]

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86909.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e3762ec-77157b8-a18fb4530859148d3f4a352c390730bfdb066fc8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e3762ec-77157b8-a1df5cc394215b2829f94b1402aaea1ef2f2c1dc/index.html

Web 🕸️
https://86909.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.55-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

Yes, help site changes are required. PR #86909 introduces a new user-facing flow where users can reuse an existing QuickBooks Desktop connection across workspaces, but the current help article (docs/articles/new-expensify/connections/quickbooks-desktop/Connect-to-QuickBooks-Desktop.md) doesn't document this.

I've created a PR with the following updates:

• Added a "How to reuse an existing QuickBooks Desktop connection" section with step-by-step instructions
• Added an FAQ entry: "Can I reuse an existing QuickBooks Desktop connection on a new workspace?"
• Updated section headings from generic "Step N" format to task-based headings per HelpDot authoring guidelines

Help site PR: #87438

[jponikarchuk]

Deploy Blocker #87457 was identified to be related to this PR.

[OSBotify]

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.57-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

👋 I reviewed the changes in this PR and confirmed that the help site article for QuickBooks Desktop needs updating.

What changed: This PR introduces the ability to reuse an existing QBD connection across workspaces. When a user clicks Set up for QBD and already has other workspaces connected to QBD, they now see an intermediate page where they can either select an existing connection to reuse or click Create new connection to go through the full Web Connector setup.

Help site impact: The current Connect-to-QuickBooks-Desktop.md article doesn't mention this new flow. I've created a draft PR with the following updates:

1. Added a new step (step 7) in the setup instructions explaining the existing connections page
2. Added a new FAQ entry: "Can I reuse an existing QuickBooks Desktop connection on a new workspace?"

Draft PR: #87549

Please review and mark it as "Ready for review" when it looks good.

[OSBotify]

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.57-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅