Update README with Expensify engineer instructions#88163
Open
NicolasBonet wants to merge 1 commit intomainfrom
Open
Update README with Expensify engineer instructions#88163NicolasBonet wants to merge 1 commit intomainfrom
NicolasBonet wants to merge 1 commit intomainfrom
Conversation
Added instructions for Expensify engineers regarding email configuration and CORS issues.
Contributor
|
👋 Hi @NicolasBonet, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
Contributor
|
@NicolasBonet I can't add a review because this issue is locked. BUT Rather than adding a note to the main doc, could we add this step in the correct place in the set up flows? It's unclear where you saw this error in your flow, even from the linked issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instructions for Expensify engineers regarding email configuration and CORS issues.
Explanation of Change
Points into the right direction after running the iOS/Android apps for expensify engineers pointing to a local VM regarding errors with using their email accounts to start using the app.
Fixed Issues
$#88164