Trying to build wheels for more systems by FLAK-ZOSO · Pull Request #61 · FLAK-ZOSO/Sista

FLAK-ZOSO · 2026-01-07T18:10:37Z

No description provided.

Copilot

Pull request overview

This PR updates the version to 3.0.0-beta.2 and expands the CI/CD pipeline to build Python wheels for multiple platforms (Linux, Windows, and macOS) instead of just Linux.

Version bumped from 3.0.0-beta.1 to 3.0.0-beta.2
Added dedicated build jobs for Windows and macOS platforms
Updated artifact upload/download to handle wheels from all three platforms

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
python/src/sista/init.pyi	Updated version string to 3.0.0-beta.2
python/src/sista/init.py	Updated version string to 3.0.0-beta.2
.github/workflows/python-publish.yml	Added Windows and macOS build jobs, updated artifact handling for multi-platform wheels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T18:15:37Z

+
+    steps:
+      - uses: actions/checkout@v4
+


The make install command will fail on Windows runners because Make is not pre-installed on windows-latest runners. While the Makefile includes Windows-specific install targets, the Make tool itself needs to be installed first. Consider either: installing Make via chocolatey (choco install make), using nmake with Visual Studio, or implementing a PowerShell-based installation script for Windows.

Suggested change

- name: Install Make

run: choco install make -y

Copilot · 2026-01-07T18:15:38Z

+      - name: Upload wheels (windows)
        uses: actions/upload-artifact@v4
        with:
-          name: release-wheels
+          name: release-wheels-windows
+          path: python/wheelhouse/


The upload path is inconsistent with where cibuildwheel will create the wheelhouse directory. Since cibuildwheel is run from the root directory without changing to the python directory, it will create the wheelhouse directory in the repository root, not in python/wheelhouse/. This will cause the upload to fail because python/wheelhouse/ won't exist. Either change to the python directory before running cibuildwheel, or update the upload path to just 'wheelhouse/'.

Copilot · 2026-01-07T18:15:38Z

+      - name: Upload wheels (macos)
+        uses: actions/upload-artifact@v4
+        with:
+          name: release-wheels-macos
          path: python/wheelhouse/


The upload path is inconsistent with where cibuildwheel will create the wheelhouse directory. Since cibuildwheel is run from the root directory without changing to the python directory, it will create the wheelhouse directory in the repository root, not in python/wheelhouse/. This will cause the upload to fail because python/wheelhouse/ won't exist. Either change to the python directory before running cibuildwheel, or update the upload path to just 'wheelhouse/'.

Copilot · 2026-01-07T18:15:38Z

+      - name: Build wheels
+        # https://cibuildwheel.pypa.io/en/stable/configuration/#environment-variables
+        run: |
+          cibuildwheel --output-dir wheelhouse


The cibuildwheel command is not being executed from the correct directory. The Linux build job changes to the python directory before running cibuildwheel (line 48: cd python), but this Windows job doesn't. Since pyproject.toml is located in the python directory, cibuildwheel needs to be run from there to find the package configuration. Either change the working directory before running cibuildwheel or specify the path as an argument.

Copilot · 2026-01-07T18:15:38Z

+        run: |
+          python -m pip install cibuildwheel
+
+      - name: Build wheels
+        run: |


The cibuildwheel command is not being executed from the correct directory. The Linux build job changes to the python directory before running cibuildwheel (line 48: cd python), but this macOS job doesn't. Since pyproject.toml is located in the python directory, cibuildwheel needs to be run from there to find the package configuration. Either change the working directory before running cibuildwheel or specify the path as an argument.

Suggested change

run: |

python -m pip install cibuildwheel

- name: Build wheels

run: |

run: |

cd python

python -m pip install cibuildwheel

- name: Build wheels

run: |

cd python

Copilot · 2026-01-07T18:15:39Z

+
+    steps:
+      - uses: actions/checkout@v4
+


The make install command will fail on Windows runners as they don't come with Make pre-installed. Windows runners typically use cmd.exe or PowerShell, and while the Makefile includes Windows support, the Make tool itself is not available by default. Consider using a Windows-specific installation approach or installing Make (e.g., via choco install make) before attempting to run this command.

Suggested change

- name: Install Make on Windows

run: choco install make -y

…d step for the Python module

…ave researched until now, and the windows-latest lacks the MinGW toolchain

…ibution)

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T16:02:36Z

+          PKG_CONFIG_PATH: ${{ github.workspace }}/python/_install/lib/pkgconfig
+          DYLD_LIBRARY_PATH: ${{ github.workspace }}/python/_install/lib
+          CIBW_BEFORE_BUILD_MACOS: "" # To prevent cibuildwheel from trying to install Sista again
+          MACOSX_DEPLOYMENT_TARGET: 15.0 # delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 11.0


The MACOSX_DEPLOYMENT_TARGET is set to 15.0, which is macOS Sequoia released in September 2024. This is an extremely recent version that will exclude most macOS users. Consider using a lower target like 11.0 or 12.0 to maintain broader compatibility with older macOS systems. If there's a specific technical reason for requiring 15.0, it should be documented.

Suggested change

MACOSX_DEPLOYMENT_TARGET: 15.0 # delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 11.0

MACOSX_DEPLOYMENT_TARGET: 11.0 # Baseline macOS target; see delocate.libsana.DelocationError note for dependencies that must support 11.0

That's what the output error told me to do, tho. We may try retrocompatibility later.

Copilot · 2026-01-08T16:02:36Z

+    ] if not is_windows else [
+        r"C:\Program Files\Sista\include"
+    ],


Hardcoded path "C:\Program Files\Sista\include" may not work in all Windows environments, especially when spaces in paths can cause issues with some build tools. Additionally, this path won't match the PREFIX used in the commented-out Windows build job which uses "${{ github.workspace }}\python\_install". Consider making this configurable via an environment variable or using a path without spaces.

Copilot · 2026-01-08T16:02:37Z

+    ] if not is_windows else [
+        r"C:\Program Files\Sista\lib"
+    ],


Hardcoded path "C:\Program Files\Sista\lib" may not work in all Windows environments. This should be consistent with the include_dirs configuration and ideally made configurable via an environment variable to support different installation locations.

Trying to build wheels for more systems

b4b2653

FLAK-ZOSO requested a review from Copilot January 7, 2026 18:10

FLAK-ZOSO self-assigned this Jan 7, 2026

FLAK-ZOSO added this to Sista collection Jan 7, 2026

FLAK-ZOSO added the enhancement New feature or request label Jan 7, 2026

FLAK-ZOSO linked an issue Jan 7, 2026 that may be closed by this pull request

Build Python wheels for more targets #60

Closed

FLAK-ZOSO moved this to In Progress in Sista collection Jan 7, 2026

Copilot started reviewing on behalf of FLAK-ZOSO January 7, 2026 18:11 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

FLAK-ZOSO added 18 commits January 7, 2026 20:16

Wrong directory fixed

e6f981d

Trying to fix include path for Windows

44bb674

MacOS - installation of the latest library is already in the pre-buil…

87bd71c

…d step for the Python module

Using a temporary user prefix, as the clanker says

c813648

Version bump for release

c03b919

Reverting Linux flow to the former, working one

23bc6ce

Adding library path for Windows

21c0dc0

Skipping before_build step on MacOS and Windows

2fb4cf6

Version bump for release

df6de2b

Fixing Linux pre_build problem

630ab1f

Fixing MacOS dependencies problem

2f6def9

Provide MSVC-friendly import library names (without "lib" prefix)

a837cbf

Version bump for release

50dd655

Comments with REM instead of # for Windows' Makefile

2e5fda3

Version bump for release

bed5cab

No more Windows, as MSVC is hardly compatible with GCC as far as we h…

8cf7aaa

…ave researched until now, and the windows-latest lacks the MinGW toolchain

Trying to upload the distribution

69fecd2

Version bump for release

fcaefac

FLAK-ZOSO had a problem deploying to pypi January 8, 2026 15:37 — with GitHub Actions Failure

Actually removing Windows stuff

a768179

FLAK-ZOSO had a problem deploying to pypi January 8, 2026 15:46 — with GitHub Actions Failure

Was supposed to be sdist (source distribution), not dist (built distr…

9b0445d

…ibution)

FLAK-ZOSO had a problem deploying to pypi January 8, 2026 15:54 — with GitHub Actions Failure

Version bump for release

5a6c9e5

FLAK-ZOSO requested a review from Copilot January 8, 2026 15:58

FLAK-ZOSO temporarily deployed to pypi January 8, 2026 15:58 — with GitHub Actions Inactive

Copilot started reviewing on behalf of FLAK-ZOSO January 8, 2026 15:58 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

FLAK-ZOSO merged commit d9ea92d into main Jan 8, 2026
25 checks passed

github-project-automation Bot moved this from In Progress to Done in Sista collection Jan 8, 2026

	MACOSX_DEPLOYMENT_TARGET: 15.0 # delocate.libsana.DelocationError: Library dependencies do not satisfy target MacOS version 11.0
	MACOSX_DEPLOYMENT_TARGET: 11.0 # Baseline macOS target; see delocate.libsana.DelocationError note for dependencies that must support 11.0

Conversation

FLAK-ZOSO commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

FLAK-ZOSO Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants