Optimized Spell Circles #908
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decreased saving/loading times
…that was made obsolete by Playerless Casting
Closed
…ptimization # Conflicts: # Common/src/main/java/at/petrak/hexcasting/common/blocks/circles/impetuses/BlockEntityRedstoneImpetus.java
| @@ -110,29 +122,34 @@ protected CircleExecutionState(BlockPos impetusPos, Direction impetusDir, Set<Bl | |||
| } | |||
|
|
|||
| if (seenGoodPosSet.add(herePos)) { | |||
| lastBlockPos.set(herePos); | |||
| // Checks to see if it should update the most positive/negative block pos | |||
There was a problem hiding this comment.
using Math.max() here would be more readable, i.e.
positiveBlock.setX(Math.max( herePos.getX(), positiveBlock.getX() ));
| public BlockPos currentPos; | ||
| public Direction enteredFrom; | ||
| public CastingImage currentImage; | ||
| public @Nullable UUID caster; | ||
| public @Nullable FrozenPigment casterPigment; | ||
| // This controls the speed of the current slate |
There was a problem hiding this comment.
variable names aren't too descriptive here, something better might be slateWait, and greaterCorner / lesserCorner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
knownPositionswith 2 Block Positions, so a AABB list would not need to be saved and loaded.Made
reachedPositionsinto a long; this is to remove a chunk ban and memory leak issue that happen when a Spell Circle loops for too long.