Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django4 #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bartsanchez
Copy link

No description provided.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 25, 2022
https://build.opensuse.org/request/show/957599
by user mcepl + dimstar_suse
- Add django4.patch to allow compatibility with Django 4
  (gh#Fantomas42/django-tagging#23).
@thomass4t
Copy link

Is this project still alive?
Having Django4 support would be great.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 30, 2022
* Add a patch to incorporate an upstream pull-request [1] to address the
  Django 2.2 deprecation [2] and set dependency to Django 3.2.

PR:		263216, 261313 [2]
Obtained from:	[1] Fantomas42/django-tagging#23
ocochard pushed a commit to ocochard/freebsd-ports that referenced this pull request Jul 6, 2022
* Add a patch to incorporate an upstream pull-request [1] to address the
  Django 2.2 deprecation [2] and set dependency to Django 3.2.

PR:		263216, 261313 [2]
Obtained from:	[1] Fantomas42/django-tagging#23
@satels
Copy link

satels commented Oct 25, 2022

??

@N1K1TAS95
Copy link

Any updates?

@tijuca
Copy link

tijuca commented Jan 15, 2023

We use the patches from this PR also within Debian to keep django-tagging within the archive usable.
Since a few days after the transition of Python 3.11 as default version the CI is reporting now failing tests.

...
  File "/usr/lib/python3/dist-packages/django/urls/resolvers.py", line 196, in _compile
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: "^(?P<tag>[^/]+(?u))/$" is not a valid regular expression: global flags not at the start of the expression at position 14
...

https://ci.debian.net/data/autopkgtest/unstable/amd64/p/python-django-tagging/29984367/log.gz

I'm not a expert for regular expressions, but to me it looks like the used regexp would need an update and adjustment. Someone of the involved people here can come up with a suggested modification? I'm happy to test that.

@thomass4t
Copy link

thomass4t commented Jan 15, 2023

The ?u is a flag to switch to Unicode matching. Placing it in the middle of the regex string was removed as it is ambigious.
Maybe it is sufficient to place (?u) at the beginning of the string (before the ^).
I would suggest to create a new issue because it has more to do with the python upgrade.

@frankystone
Copy link

@Fantomas42 looks like many people/projects uses this django-app including the widelands website which i maintain. Some reaction would be nice 😃

@jayvdb
Copy link

jayvdb commented Mar 6, 2023

Issues has been disabled on this repository. Feels like this project needs a new maintainer. https://github.com/Fantomas42 has had no github activity for two years, since late 2020. However good news is there are two other maintainers with PyPI access according to https://pypi.org/project/django-tagging/ , so we could arrange for a repo fork to take over maintenance, without needing a project rename also. @brosner and @insin , are one of you able to help ?

@CuriousLearner
Copy link

Hi @Fantomas42 , @brosner and @insin 👋🏼

Would you have time to consider making a release to support the latest Django version? Please let me know if I can help in any way.

Many thanks!

@nikolas
Copy link

nikolas commented Apr 15, 2024

I've made a new release of this library with django 4.2 support here: https://github.com/ccnmtl/django-tagging/releases/tag/0.5.1

It's not on pypi but you can use this wheel file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.