Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl: Add channel_id as output #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kozr
Copy link

@kozr kozr commented Jan 6, 2021

Description

I just added a channel id output with key channel_id

Closes: #35

kozr#7
https://github.com/kozr/action-hosting-deploy/runs/1653935215?check_suite_focus=true

Feedbacks are always welcome.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Worked on my forked repo with a new Firebase project

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@google-cla google-cla bot added the cla: yes Contributor has signed CLA label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output computed channelId
1 participant