Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl: Add channel_id as output #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Impl: Add channel_id as output #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c70cd
add channel_id as output
kozr Jan 6, 2021
a187b5c
add channel_id documentation
kozr Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/deploy-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ jobs:
echo urls ${{steps.firebase_hosting_preview.outputs.url}}
echo expire_time ${{steps.firebase_hosting_preview.outputs.expire_time}}
echo details_url ${{steps.firebase_hosting_preview.outputs.details_url}}
echo channel_id ${{steps.firebase_hosting_preview.outputs.channel_id}}
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ The time the deployed preview urls expire

A single URL that was deployed to

### `channel_id`

The channel id the action used to deploy

## Status

![Status: Experimental](https://img.shields.io/badge/Status-Experimental-blue)
Expand Down
1 change: 1 addition & 0 deletions bin/action.min.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11494,6 +11494,7 @@ async function run() {
core.setOutput("urls", urls);
core.setOutput("expire_time", expireTime);
core.setOutput("details_url", urls[0]);
core.setOutput("channel_id", channelId);
const urlsListMarkdown = urls.length === 1 ? `[${urls[0]}](${urls[0]})` : urls.map(url => `- [${url}](${url})`).join("\n");

if (token && isPullRequest && !!octokit) {
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ async function run() {
setOutput("urls", urls);
setOutput("expire_time", expireTime);
setOutput("details_url", urls[0]);
setOutput("channel_id", channelId);

const urlsListMarkdown =
urls.length === 1
Expand Down