update the dependency on libtriton_jit

[iclementine]

PR Category

Other

Type of Change

Other

Description

update the dependency on libtriton_jit

Issue

Progress

• Change is properly reviewed (1 reviewer required, 2 recommended).
• Change is responded to an issue.
• Change is fully covered by a UT.

Performance

[gemini-code-assist]

Summary of Changes

Hello @iclementine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the source location for the libtriton_jit dependency within the project's CMake build system. By changing the Git repository URL, the project will now pull the JIT library from a different upstream source, which could reflect a new maintainer, an updated fork, or a more stable version of the library, ensuring the build process uses the intended version of this critical component.

Highlights

• Dependency Update: The Git repository URL for the libtriton_jit dependency has been updated in the build configuration.
• Source Repository Change: The project will now fetch libtriton_jit from https://github.com/FlagTree/libtriton_jit.git instead of https://github.com/iclementine/libtriton_jit.git.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the git repository URL for the libtriton_jit dependency. While this is a good change, likely moving to an official repository, the dependency is not pinned to a specific version. I've added a comment to suggest using GIT_TAG in FetchContent_Declare to ensure reproducible builds, which is a critical best practice for managing dependencies.

[gemini-code-assist]

For build reproducibility and stability, it's highly recommended to pin this dependency to a specific commit hash or tag by adding GIT_TAG. Fetching from the default branch can lead to unexpected build failures if the dependency introduces breaking changes. This practice is already followed for the googletest dependency in this file (see GIT_TAG on line 80).

    GIT_REPOSITORY https://github.com/FlagTree/libtriton_jit.git
    GIT_TAG <commit-hash-or-tag> # TODO: Specify a tag or commit for reproducibility