Skip to content

update the dependency on libtriton_jit #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

update the dependency on libtriton_jit #978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ if(FLAGGEMS_USE_EXTERNAL_TRITON_JIT)
else()
set(TRITON_JIT_INSTALL ON) # install triton jit
FetchContent_Declare(TritonJIT
GIT_REPOSITORY https://github.com/iclementine/libtriton_jit.git
GIT_REPOSITORY https://github.com/FlagTree/libtriton_jit.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For build reproducibility and stability, it's highly recommended to pin this dependency to a specific commit hash or tag by adding GIT_TAG. Fetching from the default branch can lead to unexpected build failures if the dependency introduces breaking changes. This practice is already followed for the googletest dependency in this file (see GIT_TAG on line 80).

    GIT_REPOSITORY https://github.com/FlagTree/libtriton_jit.git
    GIT_TAG <commit-hash-or-tag> # TODO: Specify a tag or commit for reproducibility

# SOURCE_DIR <your local source dir of libtriton_jit>
)
FetchContent_MakeAvailable(TritonJIT)
Expand Down
Loading