feat: disable auto-play on seek #768
Merged
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR disables automatic playback when seeking in a paused video, aligning the behavior with the Fossify Music Player. The changes remove code that would start playback after seeking when the video was paused, ensuring that the play/pause state is preserved during seek operations.
Key changes:
- Removed auto-play logic from
onStopTrackingTouchin both video player implementations - Removed auto-play logic after drag gestures in
VideoPlayerActivity - Updated changelog to document the behavioral change
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/kotlin/org/fossify/gallery/fragments/VideoFragment.kt | Removed else clause that would call playVideo() when seeking while paused, preserving the paused state |
| app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt | Removed auto-play logic in two locations: after drag gestures (ACTION_UP) and in onStopTrackingTouch, ensuring consistency with the fragment implementation |
| CHANGELOG.md | Added entry under "Changed" section documenting that the player now respects play/pause state when seeking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt
Show resolved
Hide resolved
This keeps the behavior consistent with Music Player (see FossifyOrg/Music-Player#97)
# Conflicts: # CHANGELOG.md
naveensingh
force-pushed
the
naveensingh/disable-autoplay-on-seek
branch
from
35532ea to
48b4390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the seek behavior consistent with the Music Player (FossifyOrg/Music-Player#97).