Skip to content

feat: disable auto-play on seek #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 4 commits into from
Dec 13, 2025
Merged

feat: disable auto-play on seek #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab704ed
feat: disable auto-play on seek
naveensingh Nov 9, 2025
cf7e93c
docs: update changelog
naveensingh Dec 13, 2025
48b4390
fix: handle skipping
naveensingh Dec 13, 2025
7358d04
fix: clear scheduled callback after seeking
naveensingh Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Long press gesture to play videos at 2x speed ([#666])

### Changed
- Player now respects play/pause state when seeking

### Fixed
- Fixed opening JXL files from other apps ([#568])

Expand Down
7 changes: 2 additions & 5 deletions app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,6 @@ open class VideoPlayerActivity : BaseViewerActivity(), SeekBar.OnSeekBarChangeLi
if (forward) curr + FAST_FORWARD_VIDEO_MS else curr - FAST_FORWARD_VIDEO_MS
newPosition = newPosition.coerceIn(0, mExoPlayer!!.duration)
setPosition(newPosition)
if (!mIsPlaying) {
togglePlayPause()
}
}

private fun handleEvent(event: MotionEvent) {
Expand Down Expand Up @@ -758,7 +755,7 @@ open class VideoPlayerActivity : BaseViewerActivity(), SeekBar.OnSeekBarChangeLi
}

if (!mIsPlaying) {
togglePlayPause()
mPlayWhenReadyHandler.removeCallbacksAndMessages(null)
}
}
mIsDragged = false
Expand Down Expand Up @@ -816,7 +813,7 @@ open class VideoPlayerActivity : BaseViewerActivity(), SeekBar.OnSeekBarChangeLi
if (mIsPlaying) {
mExoPlayer!!.playWhenReady = true
} else {
togglePlayPause()
mPlayWhenReadyHandler.removeCallbacksAndMessages(null)
}

mIsDragged = false
Expand Down
5 changes: 0 additions & 5 deletions app/src/main/kotlin/org/fossify/gallery/fragments/VideoFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,9 +723,6 @@ class VideoFragment : ViewPagerFragment(), TextureView.SurfaceTextureListener,
if (forward) curr + FAST_FORWARD_VIDEO_MS else curr - FAST_FORWARD_VIDEO_MS
newPosition = newPosition.coerceIn(0, maxOf(mExoPlayer!!.duration, 0))
setPosition(newPosition)
if (!mIsPlaying) {
togglePlayPause()
}
}

override fun onProgressChanged(seekBar: SeekBar, progress: Int, fromUser: Boolean) {
Expand Down Expand Up @@ -766,8 +763,6 @@ class VideoFragment : ViewPagerFragment(), TextureView.SurfaceTextureListener,

if (mIsPlaying) {
mExoPlayer!!.playWhenReady = true
} else {
playVideo()
}

mIsDragged = false
Expand Down
Loading