Add enum column support to relational server - #3074
Merged
Merged
Conversation
Contributor
Result of fdb-record-layer-pr on Linux CentOS 7
|
ScottDugas
marked this pull request as ready for review
February 3, 2025 15:21
It conflicted because I had to re-ignore now that there is no inheritance in the yaml testing framework.
g31pranjal
reviewed
Feb 11, 2025
Comment on lines
+324
to
+326
| // Probably an enum, it's not clear exactly how we should handle this, but we currently only have one | ||
| // thing which appears as OTHER | ||
| o = getString(oneBasedColumn); |
Member
There was a problem hiding this comment.
I think this is mostly in line as to what we have in other parts of the system (in DirectAccessAPI etc.) but we should formally decide as to how we want to treat our ENUMs. I think most of the DBs actually map it to either a STRING or INTEGER externally and do an implicit cast internally, but they loose some bits of type info in the way to do so.
g31pranjal
previously approved these changes
Feb 11, 2025
g31pranjal
left a comment
g31pranjal
left a comment
Member
There was a problem hiding this comment.
This was much needed since a long time! Thanks for tackling this.
Also, sorry for the delay
Conflicts on YamlIntegrationTests because the annotation was changed for the two enum tests on `main`, and the annotation was removed here.
g31pranjal
approved these changes
Feb 11, 2025
ScottDugas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3073