Added default argument for instantiating ToxicityFilter class#363
Open
saqibns wants to merge 3 commits into
Open
Added default argument for instantiating ToxicityFilter class#363saqibns wants to merge 3 commits into
saqibns wants to merge 3 commits into
Conversation
AbinayaM02
approved these changes
Nov 25, 2021
Collaborator
AbinayaM02
left a comment
AbinayaM02
left a comment
There was a problem hiding this comment.
Hi @saqibns: Thank you for adding this enhancement. Please pull the main once and we can merge your changes.
aadesh11
reviewed
Nov 25, 2021
| @@ -24,7 +24,7 @@ class ToxicityFilter(SentenceOperation): | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
It would be great if you can add docstring for your classes and functions.
aadesh11
reviewed
Nov 25, 2021
| @@ -24,7 +24,7 @@ class ToxicityFilter(SentenceOperation): | |||
|
|
|||
| def __init__( | |||
Collaborator
There was a problem hiding this comment.
Please add keywords for your filter.
…oxicity_filter_update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a default argument to enable the instantiation of the
ToxicityFilterclass without providing any arguments. This was required because the evaluation interface for robustness lacks the option of providing custom options for instantiating classes.