Skip to content

Added default argument for instantiating ToxicityFilter class #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saqibns wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added default argument for instantiating ToxicityFilter class #363

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e223841
Added default argument for instantiating ToxicityFilter class
saqibns Nov 2, 2021
e246f8e
Merge branch 'main' of https://github.com/saqibns/NL-Augmenter into t…
saqibns Dec 7, 2021
392b3ff
black changes
saqibns Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion filters/toxicity/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ToxicityFilter(SentenceOperation):

Copy link
Copy Markdown
Collaborator

@aadesh11 aadesh11 Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you can add docstring for your classes and functions.

def __init__(
Copy link
Copy Markdown
Collaborator

@aadesh11 aadesh11 Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add keywords for your filter.

self,
toxicity_type: ToxicityTypes,
toxicity_type: ToxicityTypes = ToxicityTypes.TOXICITY,
op: str = ">",
threshold: float = 0.5,
):
Expand Down