Skip to content

Verify MERRA2 location; ensure correct WEMIN setting for remapping from MERRA-2 and GEOS-IT#188

Merged
sdrabenh merged 8 commits intomainfrom
feature/wjiang/verify_merra2
Mar 23, 2026
Merged

Verify MERRA2 location; ensure correct WEMIN setting for remapping from MERRA-2 and GEOS-IT#188
sdrabenh merged 8 commits intomainfrom
feature/wjiang/verify_merra2

Conversation

@weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Mar 20, 2026

Verify availability of discover:/archive directory with MERRA2 restarts. Help users by printing error message with information about Discover nodes from which this directory can be accessed.
Ensure correct WEMIN setting for remapping from MERRA-2 and GEOS-IT

Related PRs:
GEOS-ESM/GEOSldas_GridComp#166

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner March 20, 2026 14:53
@weiyuan-jiang weiyuan-jiang added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Mar 20, 2026
@gmao-rreichle gmao-rreichle changed the title Verify MERRA2 location Verify MERRA2 location; ensure correct WEMIN setting for remapping from MERRA-2 and GEOS-IT Mar 20, 2026
@gmao-rreichle gmao-rreichle marked this pull request as draft March 20, 2026 20:56
@gmao-rreichle
Copy link
Contributor

@weiyuan-jiang @mathomp4 @sdrabenh :
When working on this PR, I noticed that #174 (started by Matt in January and merged by Scott last week) removed help text that remapping from GEOS-IT and M-2 only works on Discover. See changes in lines ~80-90 of remap_questions.py.
I don't know if this was intentional or not, but for now I edited the "message" text to add the caveat about "discover only", including the bit about discover[30,36] for M-2 restarts, see f40b6e3
Two questions:

  1. I can't tell if the aforementioned change in v11: Ask GEOS-IT question first, look for MERRA-2 #174 was intentional or inadvertent. If it was intentional, I would advised against it.
  2. If the change was inadvertent and some mix-up of "v11" and "v12" branches, somebody should look at v11: Ask GEOS-IT question first, look for MERRA-2 #174 again to make sure nothing else got lost in the shuffle. I see a bunch of changes that appear to be related to cleaning up or strengthening the python coding. For example, "x.get()" vs. "x[]" and the use or not of "False" in remap_questions.py.

Note that the "discover only" information for remapping from GEOS-IT and M-2 also got lost in the corresponding v12 PR #173.

For now, I changed the present PR to draft to express that it needs further scrutiny.

Please coordinate with @biljanaorescanin regarding running the remap_restarts test suite and making sure the remapping from M-2 works as intended on and off discover[30,36].

@biljanaorescanin
Copy link
Contributor

biljanaorescanin commented Mar 23, 2026

Testing Summary

  1. All remapping tests passed successfully.

  2. Functionality Testing:

On discover32:
The MERRA-2 (M2) prompt is not shown, as expected.

? Remap from archived GEOS-IT restarts? (Works only on NCCS/Discover.)
No
? Enter input directory with restart files to be remapped:

On discover36:
The MERRA-2 (M2) prompt is shown, as expected for supported nodes.

? Remap from archived GEOS-IT restarts? (Works only on NCCS/Discover.)
No
? Remap from archived MERRA-2 restarts? (Works only on NCCS/Discover nodes

And all other questions and final results worked as expected.

@biljanaorescanin biljanaorescanin marked this pull request as ready for review March 23, 2026 14:46
@gmao-rreichle
Copy link
Contributor

@biljanaorescanin : It looks like you tested the interactive questions for remap_restarts directly. Did you try specifying RESTART='M' in GEOSldas and verify that setup exits with a useful error message? Not sure I understand your test summary correctly

@sdrabenh sdrabenh merged commit cb5c52a into main Mar 23, 2026
19 checks passed
@sdrabenh
Copy link
Contributor

sdrabenh commented Mar 23, 2026

@gmao-rreichle sorry I missed seeing your last comment before I merged. Do we need to revert?

@gmao-rreichle
Copy link
Contributor

@gmao-rreichle sorry I missed seeing your last comment before I merged. Do we need to revert?

@sdrabenh : No worries. Let's wait for @biljanaorescanin to respond. It's probably all good. If we need to make changes, we can just start a new PR. Even if the current PR has flaws, it shouldn't be a problem to keep "main" as is in the meantime

@biljanaorescanin
Copy link
Contributor

@gmao-rreichle I planned to leave that comment on GEOSldas_GridComp PR#166 once all regression tests are done...

Yes, option "M" in GEOSldas was tested an all looked good.

That was done before I left comment on this PR.

@gmao-rreichle
Copy link
Contributor

Thanks, @biljanaorescanin! @sdrabenh : No need to revert, then.

@gmao-rreichle gmao-rreichle deleted the feature/wjiang/verify_merra2 branch March 23, 2026 18:03
@sdrabenh
Copy link
Contributor

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants