Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new cycling 3DVar suite for GEOS-CF. The experiment is designed to run a 12h forecast starting from the beginning of the assimilation window and apply the increment from the middle of the window using IAU. The forecast length and frequency can be set using
forecast_lengthandforecast_output_frequencybut I didn't test changing the forecast length.Summary of changes:
RC files that get templated with SWELL are in
src/swell/configuration/jedi/interfaces/geos_cf/namelists. The remaining RC files (static) are copied into the scratch directory from geos_cf_run_dir.get_backgroundtask fetches backgrounds from R2D2 usingbackground_experimentin the config as the experiment ID. In cycling experiments (those with "cycle" in their name), the experiment ID is set tobackground_experimentfor the first cycle. For subsequent cycles, it is set to ther2d2_experiment_idof the current experiment, so that backgrounds from the previous cycle are fetched for the variational task in the current one.save_forecasttask stores forecasts in R2D2 using r2d2_experiment_idas the experiment ID. These files are then fetched from R2D2 during theget_backgroundtask.Restarts are saved (
save_restart) and fetched (get_restart) from R2D2. To save space, restart files are not stored on R2D2 at every cycle. Therst_store_intervalkey controls how many cycles pass before restart files are stored as real files rather than symlinks. In intermediate cycles, restarts are saved as symlinks.prep_forecast prepares the scratch directory within the current cycle's run directory:
geos_cf_run_dirand copies/edits RC files fromsrc/swell/configuration/jedi/interfaces/geos_cf/namelists.inc_template.run_forecastsubmits gcm_run_geoscf.j (a lighter version ofgcm_run.jused for running GEOS-CF) to the queue and waits until the job finishes. One limitation: the Cylc interface shows this job as "running" whether it is waiting in the queue or actually executing. There may be better approaches for handlinggcm_run.jexecution.clean_cycle.pynow cleans the scratch directory of the previous cycle after the current cycle completes. This way, the restart files from the previous cycle that are saved as symlinks are kept until the current cycle uses them.