Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Aug 26, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features

    • Booth map management: Added a Back button to remove the last marker and a copy-complete alert.
    • Remittance: Payment option radios are now controlled; logos rendered more clearly.
  • Bug Fixes

    • Navigation now replaces history after order success and related actions to prevent unintended back navigation.
    • Remittance redirects to the store when the cart is empty and uses toast messages for failures.
    • Booth map: Improved marker accuracy and interaction (drag vs. click), centered markers, displays total booth count, and updated booth positions.
    • Corrected IBK bank account number formatting.

@coderabbitai
Copy link

coderabbitai bot commented Aug 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Multiple user app updates: environment files added to .gitignore; API request targets and axios usage adjusted; navigation updated to use history replace; order details query key/selection changes; remittance flow made controlled via remitValue and new Radio prop; toast-based error handling added; booth map logic/layout refined with new coordinates; minor utility map key tweak.

Changes

Cohort / File(s) Summary
Git ignore env files
apps/nowait-user/.gitignore
Ignore .env.development and .env.production.
Order API call adjustments
apps/nowait-user/src/api/order.ts
getOrderDetails now uses relative path; getStorePayments switches from configured instance to global axios with same absolute URL.
Order details page query tweaks
apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx
Renamed data to orderDetails; queryKey removes tableId; queryFn non-null asserts storeId; select uses optional chaining; added console.log; updated empty-state and rendering to use orderDetails.
Navigation replace on success pages
apps/nowait-user/src/components/common/SuccessMessagePage.tsx, apps/nowait-user/src/pages/order/orderSuccess/OrderSuccessPage.tsx
onClick navigation now uses replace: true.
Remittance flow: controlled radios and defaults
apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx, .../components/Radio.tsx, .../components/remitOptions/DirectRemitOption.tsx, .../components/remitOptions/EasyPayOptions.tsx, .../components/remitOptions/RemitOptions.tsx
Introduced remitValue state typing and mount redirect on empty cart; default selection logic updated (maps accountNumber to "direct"); Radio gains remitValue prop and becomes controlled; EasyPayOptions/DirectRemitOption pass remitValue; removed defaultChecked in favor of controlled selection.
Remittance wait: toast + replace navigation
apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx
Replaced alert with toast via useToastStore; success navigation uses replace: true; early return on failure.
Booth map manage layout/logic
apps/nowait-user/src/pages/waiting/boothMap/MapManagePage.tsx
Rebased coordinate mapping on 1100x1100 logical grid; increased precision to 3 decimals; structural/layout updates (container classes, ul/li markers); added “back/remove last” action; copy shows completion alert.
Booth map view and list
apps/nowait-user/src/pages/waiting/boothMap/MapPage.tsx, .../components/BoothList.tsx, .../constants/boothPosition.ts
Centralized boothPosition constants and expanded entries; added drag vs click distinction; marker transform centering; marker click toggles details; BoothList now accepts totalBooth prop and displays it.
Account format map tweak
apps/nowait-user/src/utils/accountFormat.ts
Changed IBK key from "IBK 기업" to IBK기업; added comment; logic unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant RW as RemittanceWaitPage
  participant API as Order API
  participant TS as useToastStore
  participant NV as Router Navigate
  participant SM as SuccessMessagePage

  U->>RW: Tap "Confirm/Pay"
  RW->>API: createOrder(payload)
  alt Success (res.success)
    note over RW,NV: Use history replace
    RW->>NV: navigate(/:storeId/order/success, { replace: true })
    NV-->>SM: Render success page
  else Failure
    RW->>TS: showToast("주문에 실패했습니다. 다시 시도해 주세요")
    RW-->>U: Stay on page
  end
Loading
sequenceDiagram
  autonumber
  actor U as User
  participant MP as MapPage
  participant BL as BoothList

  U->>MP: pointerdown
  MP->>MP: isDragging = false
  U-->>MP: pointermove (drag)
  MP->>MP: isDragging = true
  U->>MP: pointerup
  alt Dragged
    MP->>MP: Do not toggle booth detail
  else Clicked
    MP->>MP: Toggle booth detail (open/close)
  end
  MP->>BL: Render with totalBooth = storeMarkers.length
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

A rabbit taps “Pay” with a confident hop,
Toast pops up—no need for an alerting bop.
Maps now glide, clicks choose, drags slide,
Radios tune to remit on the tidy side.
One swift replace, the past slips light—
Orders bloom, and paths turn right. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f335a05 and e8141b7.

📒 Files selected for processing (16)
  • apps/nowait-user/.gitignore (1 hunks)
  • apps/nowait-user/src/api/order.ts (1 hunks)
  • apps/nowait-user/src/components/common/SuccessMessagePage.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderSuccess/OrderSuccessPage.tsx (2 hunks)
  • apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx (2 hunks)
  • apps/nowait-user/src/pages/order/remittance/components/Radio.tsx (3 hunks)
  • apps/nowait-user/src/pages/order/remittance/components/remitOptions/DirectRemitOption.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/remittance/components/remitOptions/EasyPayOptions.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/remittance/components/remitOptions/RemitOptions.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx (3 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/MapManagePage.tsx (4 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/MapPage.tsx (5 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/components/BoothList.tsx (2 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/constants/boothPosition.ts (1 hunks)
  • apps/nowait-user/src/utils/accountFormat.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from oriNuguri25 August 26, 2025 05:17
@hwangdae hwangdae merged commit 8a50661 into main Aug 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants