Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Aug 26, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features
    • Store notices now support rich HTML content for improved readability and formatting.
  • Bug Fixes
    • Improved reliability of order requests and routing across environments, reducing potential connectivity issues.
  • Style
    • Enhanced cart item typography and color for better legibility.
    • Small action buttons no longer force a white background, improving visual consistency with themes.
  • Chores
    • Updated URL rewrite rules for order-related paths to ensure correct routing behavior.

@coderabbitai
Copy link

coderabbitai bot commented Aug 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced two order API calls to use axios with relative paths; adjusted vercel rewrite to strip the “orders” prefix; updated button and cart item styles; enabled HTML rendering for store notices via dangerouslySetInnerHTML. No exported signatures changed.

Changes

Cohort / File(s) Summary
Order API call path changes
apps/nowait-user/src/api/order.ts
Switched createOrder and getOrderDetails from using the preconfigured api instance/absolute API_URI to axios with relative endpoints; response handling unchanged; getStorePayments untouched.
UI style tweaks
apps/nowait-user/src/components/SmallActionButton.tsx, apps/nowait-user/src/pages/order/orderList/components/CartItem.tsx
SmallActionButton: removed bg-white class. CartItem: typography changed to semibold and added text-black-90 for name and origin price. No behavioral changes.
Store notice HTML rendering
apps/nowait-user/src/pages/waiting/storeNotice/StoreNoticePage.tsx
Render content as HTML via dangerouslySetInnerHTML instead of plain text; structure unchanged.
Vercel rewrite adjustment
apps/nowait-user/vercel.json
Rewrote "/orders/:path*" to "https://nowait.co.kr/:path*" (removes "orders" prefix). Other rewrites/headers unchanged.

Sequence Diagram(s)

sequenceDiagram
  actor U as User Browser
  participant FE as nowait-user (Frontend)
  participant V as Vercel Edge
  participant API as nowait.co.kr

  rect rgba(230,245,255,0.6)
  note right of FE: Order APIs now use relative paths
  U->>FE: Trigger create order / fetch items
  FE->>V: axios to /orders/create|items/...
  V->>API: Rewrite to https://nowait.co.kr/:path*<br/>(strips "orders")
  API-->>V: Response (data)
  V-->>FE: Response (data)
  FE-->>U: Render order state
  end
Loading
sequenceDiagram
  actor U as User
  participant FE as StoreNoticePage
  note over FE: content rendered via dangerouslySetInnerHTML
  U->>FE: Navigate to Store Notice
  FE-->>U: HTML content injected into DOM
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • merge to main #324 — Also modifies apps/nowait-user/src/api/order.ts targeting the same order functions.
  • merge to main #351 — Changes createOrder/getOrderDetails in the opposite direction (absolute API_URI), overlapping with this PR’s edits.
  • merge to main #343 — Adjusts API_URI/base URL usage in the same file, intersecting with how endpoints are constructed.

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

I thump my paws—new paths unfurl,
Orders hop along the curl.
Buttons shed their snowy coats,
Cart names bold in tidy notes.
Notices whisper HTML,
Through safe burrows, data fell.
Carrots up—deploys go well! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6a8f9 and 8c6616a.

📒 Files selected for processing (5)
  • apps/nowait-user/src/api/order.ts (2 hunks)
  • apps/nowait-user/src/components/SmallActionButton.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderList/components/CartItem.tsx (1 hunks)
  • apps/nowait-user/src/pages/waiting/storeNotice/StoreNoticePage.tsx (1 hunks)
  • apps/nowait-user/vercel.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwangdae hwangdae merged commit 039a4a4 into main Aug 26, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from oriNuguri25 August 26, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants