merge to main

[hwangdae]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

• Refactor

  • Streamlined order requests through a unified client to improve reliability and session consistency across environments.
  • Updated routing so /orders pages are handled directly within the app, reducing external redirects and potential inconsistencies.

• Chores

  • Removed legacy proxy configuration for /orders while keeping existing image and banner rewrites intact.
  • Maintained current headers behavior for orders endpoints to ensure compatibility.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced the exported axios client with a private, environment-aware client in order.ts and updated createOrder/getOrderDetails to use it. getStorePayments continues using a full URL via axios. Removed the /orders rewrite from vercel.json; other rewrites and the catch-all remain unchanged.

Changes

Cohort / File(s)	Summary
Order API client refactor apps/nowait-user/src/api/order.ts	Made api private with dynamic baseURL ("" in development, otherwise VITE_SERVER_URI), kept withCredentials. Switched createOrder and getOrderDetails to use the private client. Left getStorePayments using axios with a full URL from API_URI. Removed export of api.
Vercel routing updates apps/nowait-user/vercel.json	Removed rewrite that proxied /orders/:path* to https://nowait.co.kr/:path*. Retained other rewrites (/api/images, /api/banner-images) and the catch-all to /index.html.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant FE as Nowait User App (Frontend)
  participant AC as Private API Client
  participant BE as Server (VITE_SERVER_URI)
  participant EXT as nowait.co.kr

  rect rgb(240,248,255)
  note right of FE: New flow (orders)
  U->>FE: Initiate order/create or fetch details
  FE->>AC: api.post("/orders") / api.get("/orders/:id")
  AC->>BE: HTTP request (withCredentials)
  BE-->>AC: Response
  AC-->>FE: Data
  FE-->>U: Render result
  end

  rect rgb(253,245,230)
  note right of FE: Previous routing (removed)
  U->>FE: Navigate to /orders/...
  FE->>EXT: Proxy via vercel.json rewrite (removed)
  EXT-->>FE: Response
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• merge to main #337: Also changes apps/nowait-user/src/api/order.ts, focusing on getStorePayments; overlaps with this module’s client/usage.
• merge to main #351: Modifies createOrder/getOrderDetails URL handling; intersects with centralizing the axios client here.
• Develop #355: Adjusts vercel.json rewrites; related to removal of the /orders rewrite in this PR.

Suggested reviewers

• dgKim1
• oriNuguri25

Poem

A bunny taps requests with gentle might,
New paths hop local, not by proxyed light.
A secret client, ears tuned to env’s song,
Orders bound to home, swift and strong.
Carrots cached, headers tight—
Ship it quick, then take a bite! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 039a4a4 and 243c1ff.

📒 Files selected for processing (2)

• apps/nowait-user/src/api/order.ts (3 hunks)
• apps/nowait-user/vercel.json (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.