Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Sep 4, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features
    • Added pop-up notifications displaying order details and order creation responses for clearer feedback during the ordering flow.
  • Bug Fixes
    • Sold-out menu items are now correctly disabled and unclickable, preventing unintended interactions.

@coderabbitai
Copy link

coderabbitai bot commented Sep 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Switches getOrderDetails API call to a root-relative path. Fixes MenuItem disabled logic to disable when sold out. Adds alert-based debugging: one on orderDetails changes in OrderDetailsPage and one showing the create-order response in RemittanceWaitPage before success checks.

Changes

Cohort / File(s) Summary of changes
Order details API path
apps/nowait-user/src/api/order.ts
Changed getOrderDetails request from ${API_URI}/orders/items/${publicCode}/${tableId} to /orders/items/${publicCode}/${tableId}; return type and signature unchanged.
Menu item interactivity
apps/nowait-user/src/components/common/MenuItem.tsx
Flipped disabled flag from !data.isSoldOut to data.isSoldOut; sold-out items are now non-clickable.
Debug alerts on pages
apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx, apps/nowait-user/src/pages/order/remittenceWait/RemittanceWait/RemittanceWaitPage.tsx
OrderDetailsPage: added useEffect to alert serialized orderDetails on change. RemittanceWaitPage: added unconditional alert of res.response after order creation request, before success checks.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant ODP as OrderDetailsPage
  participant API as api (baseURL "/")
  participant S as Server

  U->>ODP: Navigate to Order Details
  ODP->>API: GET /orders/items/{publicCode}/{tableId}
  API->>S: Request
  S-->>API: Response (OrderDetails)
  API-->>ODP: res.data
  note over ODP: useEffect alerts JSON.stringify(orderDetails) on change
Loading
sequenceDiagram
  participant U as User
  participant MI as MenuItem
  participant RWP as RemittanceWaitPage
  participant S as Server

  U->>MI: Click
  alt Item sold out (data.isSoldOut)
    MI--xU: Button disabled (no navigation)
  else Item available
    MI->>RWP: Navigate to order/remittance flow
    RWP->>S: Create order request
    S-->>RWP: Response
    note over RWP: alert(JSON.stringify(res.response)) before success check
    alt res.success
      RWP->>U: Proceed to next step
    else
      RWP->>U: Show error handling
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • merge to main #351: Also changes getOrderDetails to use API_URI; directly related but in the opposite direction of this PR.
  • merge to main #388: Modifies the same getOrderDetails endpoint base; contrasts with this PR’s shift to a relative path.
  • Develop #384: Updates getOrderDetails parameters/endpoint; touches the same function as this PR.

Suggested reviewers

  • oriNuguri25
  • dgKim1

Poem

A nibble of paths, a hop to “/orders” bright,
Buttons now rest when stock fades from sight.
Alerts squeak loudly—debugging delight! 🐇
Tables and tickets aligned just right,
Code burrows tidy, shipping tonight.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a5e9f4 and ccb9cb8.

📒 Files selected for processing (4)
  • apps/nowait-user/src/api/order.ts (1 hunks)
  • apps/nowait-user/src/components/common/MenuItem.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderDetails/OrderDetailsPage.tsx (2 hunks)
  • apps/nowait-user/src/pages/order/remittenceWait/RemittanceWaitPage.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from oriNuguri25 September 4, 2025 10:51
@hwangdae hwangdae merged commit 595a395 into main Sep 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants