Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Nov 10, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Bug Fixes
    • Compass mode now centers on user location; device orientation adjustment functionality has been removed for improved stability.

@hwangdae hwangdae merged commit aaa1e74 into main Nov 10, 2025
2 checks passed
@github-actions github-actions bot requested a review from oriNuguri25 November 10, 2025 11:00
@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The CompassButton component had device orientation event handling logic and useRef references commented out. Compass mode can still toggle on and off, but no longer responds to actual device orientation changes or requests permissions for device orientation access.

Changes

Cohort / File(s) Change Summary
Compass Button Orientation Handling
apps/nowait-user/src/pages/waiting/boothMap/components/mapControls/CompassButton.tsx
Commented out useRef import and marker reference; removed active device orientation permission requests and event listeners; compass mode toggle now operates as a no-op disable path without orientation event processing

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CompassButton
    participant Map
    participant DeviceOrientation as Device Orientation<br/>(Disabled)

    User->>CompassButton: Toggle compass on
    CompassButton->>Map: Pan to user center
    CompassButton->>CompassButton: Set compass mode = true
    Note over DeviceOrientation: ❌ No longer listens<br/>for orientation events

    User->>CompassButton: Toggle compass off
    CompassButton->>CompassButton: Set compass mode = false
    Note over DeviceOrientation: ❌ No device orientation<br/>cleanup executed
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that commenting out the orientation logic was intentional (not a work-in-progress or temporary debug state)
  • Confirm the compass UI still displays and toggles correctly without orientation input
  • Check that removing useRef doesn't cause any stale reference errors

Suggested reviewers

  • oriNuguri25

Poem

🧭 A compass without a dance,
No gyro spins, no device's prance,
Just pan and toggle, left and right,
The bearing's fixed, orientation's flight! 🐰

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff3031a and 624b84f.

📒 Files selected for processing (1)
  • apps/nowait-user/src/pages/waiting/boothMap/components/mapControls/CompassButton.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants