Exclude Basic scaling and add explicit automatic scaling to App Engine - #18277
Exclude Basic scaling and add explicit automatic scaling to App Engine#18277KannetiDivya4a7 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9ee8f0b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @KannetiDivya4a7, @melinath VCR tests complete for 9ee8f0b! |
melinath
left a comment
There was a problem hiding this comment.
I don't think this test has any diffs that need to be fixed.
9ee8f0b to
50122b4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 50122b4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @KannetiDivya4a7, @melinath VCR tests complete for 50122b4! |
|
Thanks! reverted the accidental changes to app_engine_standard_app_version.tf.tmpl and implemented the proper fix for the permadiff in the YAML file. |
|
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
melinath
left a comment
There was a problem hiding this comment.
Please fix the failing CLA check
|
@KannetiDivya4a7, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
Closing this PR as the changes have been re-raised by Dipanshu in #18555 to resolve the TVC CLA validation issue. Thanks! |

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue.
Per b/325645138, this rolls back #10000, which was intended to be a temporary fix.