Skip to content

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue. #18555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptadipanshu wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −4
Open

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue. #18555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/appengine/StandardAppVersion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ properties:
- manual_scaling
# This flattener is entirely handwritten and must be updated with **any** new field or subfield
custom_flatten: templates/terraform/custom_flatten/appengine_standardappversion_automatic_scaling_handlenil.go.tmpl
default_from_api: true
properties:
- name: maxConcurrentRequests
type: Integer
Expand Down
4 changes: 0 additions & 4 deletions mmv1/templates/terraform/samples/services/iap/iap_app_engine_service.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ resource "google_app_engine_standard_app_version" "version" {
runtime = "nodejs22"
noop_on_destroy = true

// TODO: Removed basic scaling once automatic_scaling refresh behavior is fixed.
basic_scaling {
max_instances = 5
}
entrypoint {
shell = "node ./app.js"
}
Expand Down