Skip to content

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue. - #18555

Open
guptadipanshu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
guptadipanshu:pr-takeover
Open

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue.#18555
guptadipanshu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
guptadipanshu:pr-takeover

Conversation

@guptadipanshu

Copy link
Copy Markdown

Release Note Template for Downstream PRs (will be copied)

Replaced basic scaling with explicit automatic scaling in App Engine sample to fix diff issue.

Per b/325645138, this rolls back #10000, which was intended to be a temporary fix.

appengine: fixed permadiff in `google_app_engine_standard_app_version` 

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 7, 2026
@google-cla

google-cla Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from slevenick August 7, 2026 04:32
@melinath

melinath commented Aug 7, 2026

Copy link
Copy Markdown
Member

@modular-magician reassign reviewer @melinath

@github-actions
github-actions Bot requested review from melinath and removed request for slevenick August 7, 2026 15:57
@modular-magician modular-magician added service/appengine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 7, 2026
@modular-magician

modular-magician commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a6f0bd7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
16 13 3 0
Affected Service Packages
  • appengine

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@guptadipanshu, @melinath VCR tests complete for a6f0bd7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants