Test that select tool GRS works with only one anchor #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0HyperCube Please have a look! |
rahat2134
changed the title
0HyperCube
reviewed
Mar 31, 2025
editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
Outdated
Show resolved
Hide resolved
|
@0HyperCube PTAL, If now everything is fine or not? |
0HyperCube
reviewed
Apr 2, 2025
| async fn test_grs_single_anchor() { | ||
| let mut editor = EditorTestUtils::create(); | ||
| editor.new_document().await; | ||
| editor.drag_tool(ToolType::Rectangle, 100., 100., 200., 200., ModifierKeys::empty()).await; |
There was a problem hiding this comment.
Since you've created a rectangle, this will have 4 points already.
You can create an empty layer with no points using DocumentMessage::CreateEmptyFolder (a folder is the same as a layer).
There was a problem hiding this comment.
Oh yeah right!
Just pushing the changes! Thanks for this - DocumentMessage::CreateEmptyFolder
0HyperCube
approved these changes
Apr 2, 2025
Keavon
changed the title
Keavon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a part of #2465