Skip to content

Test that select tool GRS works with only one anchor #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2025
Merged

Test that select tool GRS works with only one anchor #2502

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25e0e5e
one-anchor-point-testing implementation
rahat2134 Mar 30, 2025
35b60ba
merge conflict and hypercube reviews
rahat2134 Apr 2, 2025
c84ec46
merge conflict
rahat2134 Apr 2, 2025
ee6d97f
merge conflict
rahat2134 Apr 2, 2025
0cd386e
merge conflict
rahat2134 Apr 2, 2025
853557d
ci cd error
rahat2134 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 40 additions & 4 deletions editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,12 +702,17 @@ impl MessageHandler<TransformLayerMessage, TransformData<'_>> for TransformLayer

#[cfg(test)]
mod test_transform_layer {
use crate::messages::portfolio::document::graph_operation::transform_utils;
use crate::messages::{
portfolio::document::graph_operation::{
transform_utils,
utility_types::{ModifyInputsContext, TransformIn},
},
prelude::Message,
tool::transform_layer::transform_layer_message_handler::VectorModificationType,
};
use crate::test_utils::test_prelude::*;
// Use ModifyInputsContext to locate the transform node
use crate::messages::portfolio::document::graph_operation::utility_types::{ModifyInputsContext, TransformIn};
use crate::messages::prelude::Message;
use glam::DAffine2;
use graphene_core::vector::PointId;
use std::collections::VecDeque;

async fn get_layer_transform(editor: &mut EditorTestUtils, layer: LayerNodeIdentifier) -> Option<DAffine2> {
Expand Down Expand Up @@ -1064,4 +1069,35 @@ mod test_transform_layer {
let angle_change = ((angle_change % 360.0) + 360.0) % 360.0;
assert!((angle_change - 90.0).abs() < 0.1, "Expected rotation of 90 degrees, got: {}", angle_change);
}

#[tokio::test]
async fn test_grs_single_anchor() {
let mut editor = EditorTestUtils::create();
editor.new_document().await;
editor.drag_tool(ToolType::Rectangle, 100., 100., 200., 200., ModifierKeys::empty()).await;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've created a rectangle, this will have 4 points already.

You can create an empty layer with no points using DocumentMessage::CreateEmptyFolder (a folder is the same as a layer).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah right!

Just pushing the changes! Thanks for this - DocumentMessage::CreateEmptyFolder

let document = editor.active_document();
let layer = document.metadata().all_layers().next().unwrap();

let modification_type = VectorModificationType::InsertPoint {
id: PointId::generate(),
position: DVec2::ZERO,
};
editor.handle_message(GraphOperationMessage::Vector { layer, modification_type }).await;
editor.handle_message(ToolMessage::ActivateTool { tool_type: ToolType::Select }).await;

// Testing grab operation - just checking that it doesn't crash
editor.handle_message(TransformLayerMessage::BeginGrab).await;
editor.move_mouse(150.0, 150.0, ModifierKeys::empty(), MouseKeys::NONE).await;
editor
.handle_message(TransformLayerMessage::PointerMove {
slow_key: Key::Shift,
increments_key: Key::Control,
})
.await;
editor.handle_message(TransformLayerMessage::ApplyTransformOperation { final_transform: true }).await;

let final_transform = get_layer_transform(&mut editor, layer).await;
// Verifying a transform node was created
assert!(final_transform.is_some(), "Transform node should exist after grab operation");
}
}
Loading