Fix FLX_RENDER_TRIANGLE not rendering anything
#3505
Conversation
richTrash21
changed the title
FLX_RENDER_TRIANGLEFLX_RENDER_TRIANGLE not rendering anything
| colors[prevColorsPos] = color; | ||
| colors[prevColorsPos + 1] = color; | ||
| colors[prevColorsPos + 2] = color; | ||
| colors[prevColorsPos + 3] = color; |
There was a problem hiding this comment.
I notice colors is still used in addTriangles should that be changed as well? why does that seem to work but not this?
There was a problem hiding this comment.
Should we deprecate
colors?
Yes, but only in triangle draw item. I think colors as a feature is really nice and should stay, but with different implementation. This would also fix #2263.
I notice colors is still used in
addTrianglesshould that be changed as well? why does that seem to work but not this?
FYI, this is explained this in the description. This was also originally adressed in #3472, where colors were multiplied to transform. I was planning to make this as a sepparate pr, but it might be better to add this change here.
There was a problem hiding this comment.
I think colors as a feature is really nice and should stay, but with different implementation.
Care to make an issue detailing the ideal implementation of colors?
|
@richTrash21 Can you allow me to push commits to this branch? |
Sadly i can't. This branch is under our organization's fork and GitHub does not allow maintainers to commit changes in such cases. I did not know that beforehand. The reason why i created the branch this way is because the issues and solutions were initially discovered and fixed on another branch of this fork. This means that any changes to this branch have to come from me (or organization) and i'm currently working on them. If it would be more beneficial, i can also move this branch to my fork and open new pr where changes from maintainers will be allowed. |
|
Suggested changes for "Fix `FLX_RENDER_TRIANGLE`"
|
Thanks! |
2 participants
Fixes #3169
Fixes #2263
The problem was with use of
colorsvector for storing color transformations. As can be seen here it was a part of Graphics API in legacy versions of OpenFL and was eventually replaced by shader in #2671. NowaddQuadstores color transformations incolorMultipliersandcolorOffsets.