Fix binary op order and add unsigned instructions #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntegralPilot
changed the title
Fixes the operand order for all non-commutative signed binary operations (div_s, gt_s, lt_s, etc.) to correctly match the WebAssembly specification (stack: val2, val1 -> result: val2 op val1). Also adds support for unsigned operation instructions: - i32.gt_u, lt_u, ge_u, le_u, div_u and rem_u have been implemented in GammaCPU - GammaALU updated appropriately to support this - Tests added and updated for this new functionality to the CPU & ALU test benches
IntegralPilot
force-pushed
the
unsigned_ops
branch
from
145d763 to
5134ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the operand order for all non-commutative signed binary operations (div_s, gt_s, lt_s, etc.) to correctly match the WebAssembly specification (stack: val2, val1 -> result: val2 op val1).
Also adds support for unsigned operation instructions: