-
Notifications
You must be signed in to change notification settings - Fork 21
Implement dpnp.interp()
#2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vlad-perevezentsev
wants to merge
44
commits into
master
Choose a base branch
from
impl_of_interp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement dpnp.interp()
#2417
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
a24d367
Initial impl of dpnp.inter()
vlad-perevezentsev e2b20b0
Second impl with dispatch_vector[only floating]
vlad-perevezentsev f7d1da9
Implement interpolate_complex
vlad-perevezentsev e1b8698
Move interpolate backend to ufunc
vlad-perevezentsev 0037455
Move def interp()to dpnp_iface_mathematical
vlad-perevezentsev 7866eb8
Use dispatch vector and remove interpolate_complex_impl
vlad-perevezentsev 51b3bde
Add more backend checks
vlad-perevezentsev ecfa37d
Add support left/right args
vlad-perevezentsev 5d53f9c
Use get_usm_allocations in def interp
vlad-perevezentsev 9dbc2c5
Pass idx as std::int64_t
vlad-perevezentsev 1bafd7c
Add proper casting input array
vlad-perevezentsev 2f43fd7
Update def interp to support period args
vlad-perevezentsev ae65091
Return fp[-1] instead of right_val for x==xp[-1]
vlad-perevezentsev 771d3eb
Unskip cupy tests for interp
vlad-perevezentsev 5cda3d2
Add dpnp tests for interp
vlad-perevezentsev a65a1dd
Update docstrings for def interp()
vlad-perevezentsev 3146234
Merge master into impl_of_interp
vlad-perevezentsev 99cc8b5
Remove lines after merging
vlad-perevezentsev 5ec0738
Merge master into impl_of_interp
vlad-perevezentsev 1263eb5
Add type_check flag to cupy tests
vlad-perevezentsev 7c1fdf1
Merge master into impl_of_interp
vlad-perevezentsev b84dd7e
Add common_interpolate_checks with common utils
vlad-perevezentsev e9e357c
Reuse IsNan from common utils
vlad-perevezentsev 50e4513
Remove dublicate copy
vlad-perevezentsev dbeb313
Add _validate_interp_param() function
vlad-perevezentsev dbb1b55
Impove code coverage
vlad-perevezentsev cbe7e7a
Add sycl_queue tests for interp
vlad-perevezentsev aa102bd
Add usm_type tests for interp()
vlad-perevezentsev 28b2a52
Merge master into impl_of_interp
vlad-perevezentsev 82c657e
Fix pre-commit remark
vlad-perevezentsev b89f41a
Move value_type_of to ext/common.hpp
vlad-perevezentsev 36ee455
Address remarks
vlad-perevezentsev 92d27d8
Merge master into impl_of_interp
vlad-perevezentsev 3b0eb60
Address the rest remarks
vlad-perevezentsev 051dc50
Merge master into impl_of_interp
vlad-perevezentsev 70611c2
helper files
vlad-perevezentsev 9e06cc3
Update value_type_of to support const complex type
vlad-perevezentsev ba987dd
Add check_same_dtype() to validation_utils.hpp
vlad-perevezentsev cbf49d4
Add check_has_dtype() to validation_utils.hpp
vlad-perevezentsev fa5d07a
Use check_num_dims for left/right
vlad-perevezentsev 0a4fdff
Use check_same_dtype for left/right
vlad-perevezentsev f368c17
Add vector vesion of check_num_dims to validation_utils.hpp
vlad-perevezentsev a7d2f50
Add check_same_size to validation_utils.hpp
vlad-perevezentsev 62802f8
Merge master into impl_of_interp
vlad-perevezentsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation has a problem of not supporting
const std::complex<T>
case.Better approach could be something like:
And in future
is_complex
could be replaced with properhas_value_type
if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is good point but I would prefer
using type = typename std::remove_cv_t<T>::value_type
to ensure it works correctly withconst
typesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something like?
Then, I believe, it will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually meant removing
const
invalue_type_of_impl<T, true>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9e06cc3