Tighten up a bunch of test accurasy requirements now that have FiniteDifferences v0.11.4 #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Differences v0.11.4
simeonschaub
reviewed
Dec 1, 2020
nickrobinson251
approved these changes
Dec 2, 2020
Comment on lines
142
to
143
| # some tests struggle in fast_math mode to get accurasy so we relax it some. | ||
| frule_test(f, (x, Δx), (y, Δy); rtol=(is_fastmath_mode ? 1e-5 : 1e-7)) | ||
| rrule_test(f, Δz, (x, x̄), (y, ȳ); rtol=(is_fastmath_mode ? 1e-5 : 1e-7)) | ||
| frule_test(f, (x, Δx), (y, Δy)) |
There was a problem hiding this comment.
can we delete comment above too? (github doesn't seem to let me directly suggest that change)
|
Weird that this was passing without JuliaDiff/FiniteDifferences.jl#125 |
|
CI isn't currently functional, because travis. I believe the only test that was running was the Zygote integration GHA |
oxinabox
added a commit
that referenced
this pull request
Dec 2, 2020
Revert "Tighten up a bunch of test accurasy requirements now that have FiniteDifferences v0.11.4 (#315)"
oxinabox
added a commit
that referenced
this pull request
Dec 2, 2020
…that have FiniteDifferences v0.11.4 (#315)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284
by undoing the changes made in
9fc8c57#diff-18f60c608d1cadf3013a4e16d696c43ea9f488fa49caa48cb6b582481025bc0fR57
(well at least the once that required changing the
atol/rtol, i figure the others can stay)requires JuliaDiff/FiniteDifferences.jl#125