Remove jl_task_stack_buffer #54527
Merged
Remove jl_task_stack_buffer #54527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deprecated and unused since October 2020. While it doesn't hurt us actively, it is code that needs to be adjusted for changes to task and TLS handling for no benefit.
gbaraldi
approved these changes
May 21, 2024
fingolfin
added a commit
to fingolfin/julia
that referenced
this pull request
May 22, 2024
This reverts commit 516ab55. Unfortunately my PR was premature and broke our CI tests. I'll get rid of the last remaining `jl_task_stack_buffer` and once that is done, will re-submit the removal PR.
fingolfin
added a commit
that referenced
this pull request
May 23, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
It has been deprecated and unused since October 2020. While it doesn't hurt us actively, it is code that needs to be adjusted for changes to task and TLS handling for no benefit.
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
This reverts commit 516ab55. Unfortunately my PR was premature and broke our CI tests. I'll get rid of the last remaining `jl_task_stack_buffer` and once that is done, will re-submit the removal PR.
fingolfin
added a commit
to fingolfin/julia
that referenced
this pull request
Jan 21, 2025
This was removed previously in PR JuliaLang#54527 but had to be reverted in PR JuliaLang#54559 as one usage remained (more by accident then by design). This has since then been resolved.
fingolfin
added a commit
to fingolfin/julia
that referenced
this pull request
Jan 21, 2025
This was removed previously in PR JuliaLang#54527 but had to be reverted in PR JuliaLang#54559 as one usage remained (more by accident then by design). This has since then been resolved.
d-netto
pushed a commit
that referenced
this pull request
Jan 21, 2025
This was removed previously in PR #54527 but had to be reverted in PR #54559 as one usage remained (more by accident then by design). This has since then been resolved. This is also part of PR #56477 but that seems stalled right now, and in fact merging parts of it now may make the review of it easier later on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deprecated and unused since October 2020.
While it doesn't hurt us actively, it is code that needs to be
adjusted for changes to task and TLS handling for no benefit.