Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DLL Search Paths for Windows with Python 3.8+ #458

Closed
wants to merge 7 commits into from

Conversation

thealanjason
Copy link

Aims to Fix #457

@thealanjason
Copy link
Author

thealanjason commented Feb 11, 2024

Based on some further reading here I found that conda installs most DLLs to CONDA_PREFIX\\Library\\bin and adding this DLL search path should hopefully suffice. In conda, when we use the activate command, adding of the DLL search directory is taken care off. However, in PythonCall, we are using CondaPkg which internally uses MicroMamba, which does not handle this by default. This can be observed by issues: mamba-org/mamba#2492, mamba-org/mamba#2839.
For now we could have this fix and delete it when micromamba fixes it upstream.

thealanjason and others added 2 commits February 12, 2024 04:49
Co-authored-by: Miles Cranmer <[email protected]>
@MilesCranmer
Copy link
Contributor

Looks good to me, thanks for implementing the suggestions. Now this will just need to wait for @cjdoris input :)

I should mention I am not that knowledgeable about Windows, so take my review with a grain of salt. It would be great if there was some way to unit-test the issue that this fix would solve (i.e., broken before this change; fixed after it), but I suppose it might not be possible.

@thealanjason
Copy link
Author

I could surely write a Julia script based test for this.

@cjdoris
Copy link
Collaborator

cjdoris commented Feb 18, 2024

Closing as per this comment #457 (comment).

@cjdoris cjdoris closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find DLLs on Windows using PythonCall with Python3.8+
3 participants