-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DLL Search Paths for Windows with Python 3.8+ #458
Conversation
Based on some further reading here I found that conda installs most DLLs to |
Co-authored-by: Miles Cranmer <[email protected]>
Co-authored-by: Miles Cranmer <[email protected]>
Looks good to me, thanks for implementing the suggestions. Now this will just need to wait for @cjdoris input :) I should mention I am not that knowledgeable about Windows, so take my review with a grain of salt. It would be great if there was some way to unit-test the issue that this fix would solve (i.e., broken before this change; fixed after it), but I suppose it might not be possible. |
I could surely write a Julia script based test for this. |
Closing as per this comment #457 (comment). |
Aims to Fix #457