Skip to content

Add DLL Search Paths for Windows with Python 3.8+ #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add DLL Search Paths for Windows with Python 3.8+ #458

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b6bf2b
Add DLL Search Paths for Windows with Python 3.8+
thealanjason Feb 11, 2024
f29ded5
Try to make change compatible with JuliaCall and PythonCall
thealanjason Feb 11, 2024
1c185a0
Avoid making function
thealanjason Feb 11, 2024
0b1dea1
Update feedback from review
thealanjason Feb 11, 2024
81c7d58
delete extra line
thealanjason Feb 11, 2024
60de461
Delete for loop
thealanjason Feb 11, 2024
1feedc3
use version_info instead of hexversion
thealanjason Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pysrc/juliacall/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,29 @@ def backtrace(self):

def init():
import os
if "CONDA_PREFIX" in os.environ: #It does only when calling from PythonCall
## For Windows and Python 3.8+ we need to add dll search paths
import sys
if os.name == "nt" and sys.hexversion >= 0x308000:
conda_environment_path = os.environ["CONDA_PREFIX"]
dll_search_paths = [
conda_environment_path,
os.path.join(conda_environment_path, "Library", "mingw-w64", "bin"),
os.path.join(conda_environment_path, "Library", "usr", "bin"),
os.path.join(conda_environment_path, "Library", "bin"),
os.path.join(conda_environment_path, "Scripts"),
os.path.join(conda_environment_path, "bin")
]
for path in dll_search_paths:
if os.path.exists(path):
os.add_dll_directory(path)
import ctypes as c
import sys
import subprocess
import warnings



# importing pytorch before juliacall sometimes causes segfaults. TODO: remove
if "torch" in sys.modules:
warnings.warn(
Expand Down