Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I try and backport anything,
I want 1.4 to be a bit cleaner.
This PR is best reviewed 1 commit at a time
if VERSION
, and moves the tests about to match othersTurns out 1.4->1.6 actually can be done without any
if VERSION
@mmiller-max or perhaps @nickrobinson251 can I trouble for a review?
I would like to have this done so i can backport #20 and thus close the rest of #19