Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up release 1.4 branch #22

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Clean-up release 1.4 branch #22

merged 2 commits into from
Aug 4, 2021

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 3, 2021

Before I try and backport anything,
I want 1.4 to be a bit cleaner.

This PR is best reviewed 1 commit at a time

  • first commit removes all the if VERSION, and moves the tests about to match others
  • second commit moves all the code around to match structure of other branchs (short make backporting just work, i hope)

Turns out 1.4->1.6 actually can be done without any if VERSION

@mmiller-max or perhaps @nickrobinson251 can I trouble for a review?
I would like to have this done so i can backport #20 and thus close the rest of #19

include new tests
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #22 (236d37a) into release-1.4 (53390df) will increase coverage by 19.45%.
The diff coverage is 79.51%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.4      #22       +/-   ##
================================================
+ Coverage        60.30%   79.76%   +19.45%     
================================================
  Files                6        4        -2     
  Lines              131       84       -47     
================================================
- Hits                79       67       -12     
+ Misses              52       17       -35     
Impacted Files Coverage Δ
src/TestEnv.jl 100.00% <ø> (+87.50%) ⬆️
src/common.jl 75.00% <75.00%> (ø)
src/activate_set.jl 80.00% <80.00%> (ø)
src/activate_do.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53390df...236d37a. Read the comment docs.

@oxinabox oxinabox mentioned this pull request Aug 4, 2021
Copy link
Member

@mmiller-max mmiller-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@oxinabox oxinabox merged commit 3743b1e into release-1.4 Aug 4, 2021
@oxinabox oxinabox deleted the ox/14cleanup branch August 4, 2021 21:14
@oxinabox oxinabox mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants