Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a typo in the project folder name in package build script & fixes a bug with migrations caused by recent changes #251

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ProNotion
Copy link
Contributor

Fixes a typo in the project folder name which will prevent the nuget package from being built

… changes

PrePrepareFile should be an override method but the change create a new
method hiding the base version.
@ProNotion ProNotion changed the title Fixes a typo in the project folder name Fixes a typo in the project folder name & fixes a bug with migrations causes by recent changes Nov 24, 2023
@ProNotion ProNotion changed the title Fixes a typo in the project folder name & fixes a bug with migrations causes by recent changes Fixes a typo in the project folder name in package build script & fixes a bug with migrations causes by recent changes Nov 24, 2023
@stevetemple
Copy link
Contributor

Can confirm this fixes #245 for me

@KevinJump KevinJump merged commit 3bea70d into Jumoo:main Nov 27, 2023
1 check passed
@UmbracoReynolds
Copy link

This fix looks helpful

Is there an estimated time for this to be published to Nuget? We are in the midst of migrating and hoping this will help fix some problems we are facing.

@ProNotion ProNotion changed the title Fixes a typo in the project folder name in package build script & fixes a bug with migrations causes by recent changes Fixes a typo in the project folder name in package build script & fixes a bug with migrations causeD by recent changes Nov 30, 2023
@ProNotion ProNotion changed the title Fixes a typo in the project folder name in package build script & fixes a bug with migrations causeD by recent changes Fixes a typo in the project folder name in package build script & fixes a bug with migrations caused by recent changes Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants