Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a typo in the project folder name in package build script & fixes a bug with migrations caused by recent changes #251

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fixes a typo in the project folder name in package build script & fixes a bug with migrations caused by recent changes #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe8869
Fixes a typo in the project folder which will prevent the nuget packa…
ProNotion Nov 24, 2023
36a1d4f
Fixes #113 and potentially #245 which were broken by recent changes
ProNotion Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/build-package.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ dotnet build ..\uSyncMigrations.sln -c $env /p:$buildParams
""; "##### Packaging"; "----------------------------------" ; ""

dotnet pack ..\uSync.Migrations.Core\uSync.Migrations.Core.csproj --no-restore --no-build -c $env -o $outFolder -p:$buildParams
dotnet pack ..\uSync.Migrations.Clients\uSync.Migrations.Client.csproj --no-restore --no-build -c $env -o $outFolder -p:$buildParams
dotnet pack ..\uSync.Migrations.Client\uSync.Migrations.Client.csproj --no-restore --no-build -c $env -o $outFolder -p:$buildParams
dotnet pack ..\uSync.Migrations.Migrators\uSync.Migrations.Migrators.csproj --no-restore --no-build -c $env -o $outFolder -p:$buildParams
dotnet pack ..\uSync.Migrations\uSync.Migrations.csproj --no-restore --no-build -c $env -o $outFolder -p:$buildParams

Expand Down
4 changes: 2 additions & 2 deletions uSync.Migrations.Core/Handlers/Shared/SharedDataTypeHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ protected override void PrepareFile(XElement source, SyncMigrationContext contex
context.DataTypes.GetByDefinition(dtd)!.OriginalEditorAlias = editorAlias;
}
}

public void PrePrepareFiles(XElement source, SyncMigrationContext context)
protected override void PrePrepareFile(XElement source, SyncMigrationContext context)
{
var editorAlias = GetEditorAlias(source);
var (alias, dtd) = GetAliasAndKey(source, context);
Expand Down