Resolve thrust related Advanced Sorting issues#34
Open
Poodmund wants to merge 2 commits intoKSPModStewards:devfrom
Open
Resolve thrust related Advanced Sorting issues#34Poodmund wants to merge 2 commits intoKSPModStewards:devfrom
Poodmund wants to merge 2 commits intoKSPModStewards:devfrom
Conversation
…h 'ModuleEngines' Current logic only allows for ModuleEnginesFX part module, missing majority of stock and old modded parts. - Changed to search for part module starting with 'ModuleEngines'. - Resolved div/0 edge case where vacuum Isp could be zero. - Consistently sorted sorter key lines for Vac and ASL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current logic only allows for ModuleEnginesFX part module, missing majority of stock and old modded parts.