Skip to content

Resolve thrust related Advanced Sorting issues #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Poodmund wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Resolve thrust related Advanced Sorting issues #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f8bf47
Extend advanced sorting capability to all engine modules starting wit…
Poodmund Dec 27, 2025
c1ab06e
Spaces > Tabs
Poodmund Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions Source/VABOrganizer/AvailablePartData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ void ProcessModule_RCS(ConfigNode node)
}
void ProcessModule_Engine(ConfigNode node)
{
if (node.GetValue("name") == "ModuleEnginesFX")
var engineModuleName = node.GetValue("name");
if (!string.IsNullOrEmpty(engineModuleName) && engineModuleName.StartsWith("ModuleEngines"))
{
float thrust = 0f;
ConfigNode ispCurveNode = new ConfigNode();
Expand All @@ -341,19 +342,26 @@ void ProcessModule_Engine(ConfigNode node)
FloatCurve ispCurve = new FloatCurve();
ispCurve.Load(ispCurveNode);

float mdot = thrust / (ispCurve.Evaluate(0f) * (float)PhysicsGlobals.GravitationalAcceleration);
float thrustASL = mdot * (ispCurve.Evaluate(1f) * (float)PhysicsGlobals.GravitationalAcceleration);
float ispVac = ispCurve.Evaluate(0f);
float ispASL = ispCurve.Evaluate(1f);

float mdot = 0f;
float thrustASL = 0f;

if (ispVac > 0.0001f)
{
thrustASL = thrust * (ispASL / ispVac);
}

AddSorterKey("ModuleVar_EngineThrustVacuum", thrust, "MAX");
AddSorterKey("ModuleVar_EngineThrustASL", thrustASL, "MAX");

AddSorterKey("ModuleVar_EngineTWRASL", thrustASL / basePart.MinimumMass, "MAX");
AddSorterKey("ModuleVar_EngineTWRVacuum", thrust / basePart.MinimumMass, "MAX");
AddSorterKey("ModuleVar_EngineTWRASL", thrustASL / basePart.MinimumMass, "MAX");

AddSorterKey("ModuleVar_EngineIspASL", ispCurve.Evaluate(1f), "MAX");
AddSorterKey("ModuleVar_EngineIspVacuum", ispCurve.Evaluate(0f), "MAX");
AddSorterKey("ModuleVar_EngineIspVacuum", ispVac, "MAX");
AddSorterKey("ModuleVar_EngineIspASL", ispASL, "MAX");
}

}
}
}
Expand Down