Fix automatic compaction closure races

[KeenWill]

Summary

Fixes three review findings from the already-deployed automatic compaction failure slice:

• locks delegated parent/child endpoint sessions before the child scheduler when a failed compaction terminalizes a delegated turn;
• retries only freshly reminted failure-entry/frontier collisions, returning immutable activation-identity collisions to the outer scheduler pass;
• derives the domain test's expected starting entry and session from its fixture.

Meaningfully changed lines: 72 (57 added, 15 removed; no lockfiles).

Validation

• cargo fmt --all -- --check
• all-feature workspace check and Clippy
• focused domain and daemon unit tests
• exact ignored PostgreSQL process-runtime compaction-failure test
• doctests, metadata, invariant/domain-spine/numeric-bound/migration/panic/PostgreSQL-manifest checks, and pinned mdformat
• full workspace tests reached only established host-fixture failures (fake-executable races, timezone data, and timing-sensitive socket/repository-watch cases)

The inherited docs-consistency carrier check remains red because live-only PR #1125 is not yet in main; its 267 checker self-tests pass. Rustdoc generated every workspace crate without warnings, then its wrapper did not exit after the final crate.

Live deploy

Deployed 115c6f97a through deploy/dogfood-live after a clean drain. Startup completed migration, recovery, socket binding, and goal rearm; the socket and 127.0.0.1:37231 listener are healthy, projections advance, and the initial census was 15 active / 0 silent / 0 stale turns.

Numeric-bound ceilings added: none.

Absorbed-PR ledger: #1030 at eeee1c5b5; #1028 at 4cdc5dfbc; #1125 at 546600143.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d3d2d68-c1bc-4928-9625-f2bf305bbf9b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate billing to continue.

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for security reviews. Please try again later.

[github-actions]

Rust coverage (report only)

Report only. This measurement has no threshold, gates no merge, and
fails no check; it exists so untested code stays visible.

Measured suite	Outcome
workspace (--all-targets --all-features)	success
persistence PostgreSQL (--ignored)	success
signalboxd PostgreSQL (--ignored)	failure
terminal-client PostgreSQL (--ignored)	success

What this number does not measure

• Doctests. cargo llvm-cov --doctests needs a nightly
  toolchain; this workspace pins stable, so the compile-fail
  sealing proofs and every other doctest are outside the
  denominator.
• Live smokes, which spend real network requests or
  credentials and are never run here: the tools-github and
  tools-web smokes stay --ignored, and the whole-daemon and
  real-provider terminal smokes are skipped by name above.
• The Swift native client, which Xcode measures separately.
• One environment-clearing test in signalbox-tools-exec,
  which instrumenting its supervisor process perturbs. The
  workflow comment on the workspace step states why; rust.yml
  runs that test uninstrumented and gates on it.
• Dedicated test files. cargo-llvm-cov excludes tests/
  and benches/ targets and *tests.rs modules from the
  report by default, so that test code is counted neither
  covered nor uncovered here. Inline #[cfg(test)] modules
  inside a source file are the exception: they are
  instrumented, and they land on both sides. A test body
  that ran counts as covered, which makes every percentage
  below optimistic; the body of an #[ignore]d test no
  measured suite runs counts as uncovered, which puts test
  lines into the file ranking. Read both tables as close,
  not exact.

Measure	Covered	Total	Percent
Lines	254072	311518	81.56%
Functions	20719	25184	82.27%
Regions	321850	402960	79.87%

Per crate, least-covered first

Crate	Line %	Lines	Function %	Region %
crates/program-runtime	7.57%	38/502	5.77%	6.13%
crates/runner-wire	60.41%	644/1066	62.67%	59.14%
apps/signalboxd	63.56%	35495/55848	70.75%	63.46%
crates/tools-sessions	65.06%	378/581	63.29%	61.68%
apps/signalbox-runner	69.47%	1784/2568	70.93%	70.29%
crates/approval-judge-eval	73.87%	492/666	76.12%	76.41%
crates/tool-schema-derive	74.20%	279/376	88.00%	72.42%
crates/tools-basic	75.37%	771/1023	66.15%	79.16%
crates/model-runtime-claude-cli	76.51%	1655/2163	73.10%	77.37%
crates/tools-github	77.06%	2408/3125	74.19%	74.82%
crates/tools-exec	77.69%	5191/6682	75.04%	74.00%
apps/client	78.88%	13283/16840	89.58%	75.76%
crates/persistence	79.93%	53968/67519	77.92%	75.34%
crates/tools-code-host	80.39%	7089/8818	80.46%	76.60%
crates/blob-store-filesystem	80.50%	1371/1703	70.17%	80.45%
crates/model-provider-runtime	81.37%	2463/3027	85.71%	79.97%
crates/blob-store	82.31%	307/373	75.41%	83.49%
crates/tools-conversations	83.01%	508/612	83.78%	77.65%
crates/egress-transport	85.35%	134/157	83.33%	77.61%
crates/conversation-import-claude-code	85.45%	740/866	66.09%	84.67%
crates/tools-plan	85.71%	768/896	88.89%	81.74%
crates/conversation-import-codex	85.76%	873/1018	64.00%	83.56%
crates/tools-workspace	86.36%	2977/3447	82.14%	87.30%
crates/tools-web	86.59%	2978/3439	87.93%	85.03%
crates/tools-git	87.40%	8750/10011	86.50%	83.24%
crates/application	88.65%	19184/21640	87.86%	88.81%
crates/model-runtime-codex-cli	90.01%	1550/1722	90.98%	89.96%
crates/test-bin	90.91%	10/11	100.00%	70.00%
crates/domain	92.29%	60212/65245	91.37%	94.13%
crates/web-contract	92.31%	408/442	82.61%	82.09%
crates/conversation-import-json	92.51%	284/307	96.88%	91.36%
crates/model-runtime-openai	93.55%	3812/4075	97.50%	91.72%
crates/process-protocol	93.67%	8469/9041	95.89%	86.68%
crates/model-runtime-anthropic	93.88%	3910/4165	97.51%	91.26%
crates/model-runtime	93.99%	9224/9814	93.39%	94.73%
crates/expect-table	95.60%	977/1022	100.00%	95.75%
crates/tool-contract	97.18%	688/708	96.47%	95.54%

25 files with the most uncovered lines

File	Uncovered lines	Line %
apps/signalboxd/src/process_runtime.rs	6580	53.40%
apps/signalboxd/src/repo_watch_runtime.rs	2235	69.20%
apps/signalboxd/src/runner_protocol_runtime.rs	2212	34.75%
crates/persistence/src/submit_input.rs	2071	71.81%
apps/client/src/lib.rs	1697	79.51%
apps/signalboxd/src/review_orchestration_runtime.rs	1333	2.56%
apps/signalboxd/src/main.rs	1303	47.46%
crates/persistence/src/model_execution.rs	1269	84.34%
crates/domain/src/turn_eligibility.rs	1223	90.33%
crates/persistence/src/runner_protocol.rs	1157	82.16%
crates/tools-code-host/src/code_host/github.rs	1052	76.26%
crates/persistence/src/review_workflow.rs	997	77.35%
crates/tools-exec/src/bin/signalbox-exec-supervisor.rs	885	45.61%
crates/persistence/src/tool_loop.rs	749	76.07%
crates/tools-github/src/lib.rs	717	76.47%
apps/signalboxd/src/convergence_sweep_runtime.rs	683	22.21%
crates/persistence/src/process_read.rs	681	82.33%
apps/client/src/presentation.rs	680	80.55%
apps/signalboxd/src/lib.rs	647	72.20%
crates/domain/src/submit_input.rs	640	88.03%
apps/signalboxd/src/daemon_tools.rs	573	89.68%
crates/process-protocol/src/lib.rs	572	93.67%
crates/persistence/src/review_orchestration.rs	569	75.66%
crates/persistence/src/session_delegation.rs	543	77.63%
crates/application/src/model_execution.rs	541	86.15%

Measured at 0d2fc315a98c14c774542f7ff1f5173e9046936a, the merge commit this pull request builds, whose head is 115c6f97ab9b584147158c8ea04e0d4982b006c2, by run 32626875060, which uploads the HTML report and LCOV as an artifact.

[codecov]

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (099ef44) to head (115c6f9).

Files with missing lines	Patch %	Lines
crates/persistence/src/start_eligible_turn.rs	0.00%	3 Missing ⚠️
apps/signalboxd/src/context_guard.rs	94.73%	1 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
rust	82.80% <87.50%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.