Skip to content

Clean up legacy build error and build failure models#3433

Open
williamjallen wants to merge 4 commits intoKitware:masterfrom
williamjallen:build-error-failure-business-logic
Open

Clean up legacy build error and build failure models#3433
williamjallen wants to merge 4 commits intoKitware:masterfrom
williamjallen:build-error-failure-business-logic

Conversation

@williamjallen
Copy link
Collaborator

Incremental progress towards the eventual combination of these models. The last significant difference between these models is the build failure arguments, which I plan to address in a follow-up PR.

@williamjallen williamjallen added this to the v4.10 milestone Feb 3, 2026
@williamjallen williamjallen force-pushed the build-error-failure-business-logic branch from 341a5fd to 59ba1a0 Compare February 3, 2026 20:30
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some errors on attempting to load Build Error and Build warnings in both new and old data. Both are 500 responses:

  • str_contains(): Argument #1 ($haystack) must be of type string, null given
  • basename(): Argument #1 ($path) must be of type string, null given

Each prevents the load of information into each page
Using testing Trilinos Data:

Image

Using newly submitted build failures:
Image

@williamjallen williamjallen force-pushed the build-error-failure-business-logic branch from 59ba1a0 to 90277c5 Compare February 4, 2026 20:48
@williamjallen
Copy link
Collaborator Author

@josephsnyder It looks like that error was caused by reviewing #3432 and then switching to this branch (the same thing that caused conflicts). I just rebased, and the error should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants