Added LocalTime.Formats.ISO_BASIC (ISO 8601 basic format) #518
Conversation
|
ISO 8601 specifies that the format for time-of-day includes a leading |
|
You are right, thanks for spotting this! I believe the same should also apply to LocalTime.Formats.ISO. Should I attempt to change it as well? |
The extended ISO format is allowed to omit the In fact, regarding usefulness: is |
|
I find it very useful, for example if one need to have a timestamp stored in a file name, in my case |
| @@ -279,6 +279,23 @@ internal class LocalTimeFormat(override val actualFormat: CachedFormatStructure< | |||
| } | |||
|
|
|||
| // these are constants so that the formats are not recreated every time they are used | |||
| internal val ISO_TIME_BASIC by lazy { | |||
| LocalTimeFormat.build { | |||
| char('T') | |||
There was a problem hiding this comment.
Please see internal val ISO_DATETIME: our format is case-insensitive.
| * | ||
| * @sample kotlinx.datetime.test.samples.LocalTimeSamples.Formats.isoBasic | ||
| */ | ||
| public val ISO_BASIC: DateTimeFormat<LocalTime> |
There was a problem hiding this comment.
Please also add tests. Examples: LocalDateTimeFormatTest#testIso, LocalDateFormatTest#testBasicIso, etc.
| /** | ||
| * ISO 8601 basic format. | ||
| * | ||
| * Examples: `1234`, `123456`, `123456.789`, `123456.1234`. |
There was a problem hiding this comment.
These examples are not valid for this format.
No description provided.