-
Notifications
You must be signed in to change notification settings - Fork 110
Added LocalTime.Formats.ISO_BASIC (ISO 8601 basic format) #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -197,6 +197,18 @@ public expect class LocalTime : Comparable<LocalTime> { | |
* [kotlinx.datetime.format.DateTimeFormat] for [LocalTime] values. | ||
*/ | ||
public object Formats { | ||
/** | ||
* ISO 8601 basic format. | ||
* | ||
* Examples: `1234`, `123456`, `123456.789`, `123456.1234`. | ||
* | ||
* When formatting, seconds are always included, even if they are zero. | ||
* Fractional parts of the second are included if non-zero. | ||
* | ||
* @sample kotlinx.datetime.test.samples.LocalTimeSamples.Formats.isoBasic | ||
*/ | ||
public val ISO_BASIC: DateTimeFormat<LocalTime> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also add tests. Examples: |
||
|
||
/** | ||
* ISO 8601 extended format. | ||
* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,6 +279,23 @@ internal class LocalTimeFormat(override val actualFormat: CachedFormatStructure< | |
} | ||
|
||
// these are constants so that the formats are not recreated every time they are used | ||
internal val ISO_TIME_BASIC by lazy { | ||
LocalTimeFormat.build { | ||
char('T') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see |
||
hour() | ||
minute() | ||
alternativeParsing({ | ||
// intentionally empty | ||
}) { | ||
second() | ||
optional { | ||
char('.') | ||
secondFraction(1, 9) | ||
} | ||
} | ||
} | ||
} | ||
|
||
internal val ISO_TIME by lazy { | ||
LocalTimeFormat.build { | ||
hour() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples are not valid for this format.