Fix u Dirichtlet condition in GeoMechanicsApplication by earlier initialization of the constitutive law #13014
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kp format changes.
rfaasse
reviewed
Jan 17, 2025
Comment on lines
149
to
154
| std::vector<Vector> strain_vectors; | ||
| strain_vectors.resize(number_of_integration_points); | ||
| for (auto& r_strain_vector : strain_vectors) { | ||
| r_strain_vector.resize(GetStressStatePolicy().GetVoigtSize()); | ||
| std::fill(r_strain_vector.begin(), r_strain_vector.end(), 0.0); | ||
| } |
There was a problem hiding this comment.
In theory, I think this could be shortened to:
Suggested change
| std::vector<Vector> strain_vectors; | |
| strain_vectors.resize(number_of_integration_points); | |
| for (auto& r_strain_vector : strain_vectors) { | |
| r_strain_vector.resize(GetStressStatePolicy().GetVoigtSize()); | |
| std::fill(r_strain_vector.begin(), r_strain_vector.end(), 0.0); | |
| } | |
| std::vector<Vector> strain_vectors(number_of_integration_points, ZeroVector(GetStressStatePolicy().GetVoigtSize()); |
rfaasse
approved these changes
Jan 17, 2025
| @@ -146,14 +146,20 @@ void UPwBaseElement::Initialize(const ProcessInfo& rCurrentProcessInfo) | |||
| std::fill(r_stress_vector.begin(), r_stress_vector.end(), 0.0); | |||
| } | |||
| } | |||
| std::vector<Vector> strain_vectors(number_of_integration_points, | |||
There was a problem hiding this comment.
Can be const, but please only do this if you have another reason you'd need to wait on the pipelines.
avdg81
added a commit
that referenced
this pull request
Jan 24, 2025
… from `InitializeSolutionStep` (#13027) In [PR #13014](#13014), initialization of material response has been added to the element initialization. Previously, that was done by the initialization of the solution step. It was, however, not removed there. Now it has been. Data member `mIsInitialised` was no longer needed, since the implicit assumption of class `UPwBaseElement` is that member function `Initialize` must be called prior to calling `InitializeSolutionStep`. A handful of unit tests lacked the call to `Initialize` prior to calling `InitializeSolutionStep`, and therefore started to fail. Those tests have been fixed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u Dirchlet conditions in GeoMechanics application were not working, because the constitutive law strain members were initialized after application of the condition. That is too late and leads to zero unbalance from this load.
🆕 Changelog
Call the strain and stress initialization for the constitutive law in Initialize of the UPW base class already.