Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update hello-world-avs example #212

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ jobs:
with:
key: docker-${{ runner.os }}-${{ hashFiles('Makefile', 'examples', 'src/config/default_config.yaml') }}

# TODO: fix the hello-world example
- name: Run example '${{ matrix.example }}'
if: matrix.example != 'kurtosis_hello_world'
run: make ${{ matrix.example }}

# TODO: fix the hello-world example
- name: Check example is still running
if: matrix.example != 'kurtosis_hello_world'
run: make check_devnet

- name: Print logs
if: always()
run: kurtosis service logs devnet

kurtosis_lint:
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ check_devnet:

# hello-world-avs example

# Version from 2025-01-04
HELLO_WORLD_REF:=4626e206fd119b26ebe98935b256daa7256e863b
# Version from 2025-02-18 (PR #108)
HELLO_WORLD_REF:=f2e76cf710c3492cc1db16b3cef2f3a5adf502f4

examples/hello-world-avs:
@echo "Cloning hello-world-avs repo..."
Expand Down
21 changes: 18 additions & 3 deletions examples/hello_world.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,26 @@
deployments:
- name: EigenLayer
repo: "https://github.com/Layr-Labs/hello-world-avs.git"
ref: "001dc6e944280559dfb44f75faf5102349a61d8e"
# Version from 2025-02-18 (PR #108)
ref: "f2e76cf710c3492cc1db16b3cef2f3a5adf502f4"
contracts_path: "contracts"
script: script/DeployEigenLayerCore.s.sol
script: script/DeployEigenLayerCore.s.sol:DeployEigenlayerCore
env:
# NOTE: this is used inside the deployer script
PRIVATE_KEY: "{{.deployer_private_key}}"
# NOTE: these are needed because of repo's `foundry.toml`
HOLESKY_PRIVATE_KEY: ""
HOLESKY_RPC_URL: ""
ETHERSCAN_API_KEY: ""
input:
config/core/: core_deployment_config
output:
eigenlayer_addresses: "deployments/core/31337.json"

- name: hello-world-avs
repo: "https://github.com/Layr-Labs/hello-world-avs.git"
ref: "001dc6e944280559dfb44f75faf5102349a61d8e"
# Version from 2025-02-18 (PR #108)
ref: "f2e76cf710c3492cc1db16b3cef2f3a5adf502f4"
contracts_path: "contracts"
script: script/HelloWorldDeployer.s.sol
env:
Expand All @@ -31,6 +35,7 @@ deployments:
ETHERSCAN_API_KEY: ""
input:
deployments/core/: eigenlayer_addresses
config/hello-world/: avs_deployment_config
output:
avs_addresses: "deployments/hello-world/31337.json"

Expand Down Expand Up @@ -65,6 +70,16 @@ keys:
- name: traffic_generator_ecdsa_keys
type: ecdsa

artifacts:
core_deployment_config:
files:
31337.json:
static_file: "https://raw.githubusercontent.com/Layr-Labs/hello-world-avs/f2e76cf710c3492cc1db16b3cef2f3a5adf502f4/contracts/config/core/31337.json"
avs_deployment_config:
files:
31337.json:
static_file: "https://raw.githubusercontent.com/Layr-Labs/hello-world-avs/f2e76cf710c3492cc1db16b3cef2f3a5adf502f4/contracts/config/hello-world/31337.json"

ethereum_package:
additional_services:
- blockscout
Expand Down
15 changes: 14 additions & 1 deletion examples/hello_world_local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ deployments:
- name: EigenLayer
repo: "."
contracts_path: "contracts"
script: script/DeployEigenLayerCore.s.sol
script: script/DeployEigenLayerCore.s.sol:DeployEigenlayerCore
env:
# NOTE: this is used inside the deployer script
PRIVATE_KEY: "{{.deployer_private_key}}"
# NOTE: these are needed because of repo's `foundry.toml`
HOLESKY_PRIVATE_KEY: ""
HOLESKY_RPC_URL: ""
ETHERSCAN_API_KEY: ""
input:
config/core/: core_deployment_config
output:
eigenlayer_addresses: "deployments/core/31337.json"

Expand All @@ -39,6 +41,7 @@ deployments:
ETHERSCAN_API_KEY: ""
input:
deployments/core/: eigenlayer_addresses
config/hello-world/: avs_deployment_config
output:
avs_addresses: "deployments/hello-world/31337.json"

Expand Down Expand Up @@ -73,6 +76,16 @@ keys:
- name: traffic_generator_ecdsa_keys
type: ecdsa

artifacts:
core_deployment_config:
files:
31337.json:
static_file: "contracts/config/core/31337.json"
avs_deployment_config:
files:
31337.json:
static_file: "contracts/config/hello-world/31337.json"

ethereum_package:
additional_services:
- blockscout
Expand Down
Loading